Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4009839pxb; Mon, 1 Feb 2021 10:03:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJwBvhuvkOg2BpNB50ZGw8qmQW/q3pmJQPosgBWprZGEoWn7HbO/k/5Zhgtkjv6zbURFUCAh X-Received: by 2002:aa7:d399:: with SMTP id x25mr6412228edq.237.1612202586790; Mon, 01 Feb 2021 10:03:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612202586; cv=none; d=google.com; s=arc-20160816; b=qGBGlghfxtGZHYo4pGF8yjeFnITYZJTWuprTNkKIEwXjvQVC2Y/5f97mG/HTXlnBh/ iS+oWiM6w882ufjdvO+h0SfqaF9ygkAoFfOrwcTdGmS9SshaJp5USDBN+Nb/7g2gtqX0 rS6RrH8vndttZwz8B70Vo7VCaHqXwKJdAcpmdFNtgy1gQgIct0ZeV8RKmqoKQlm53n9N LAhXm4ymnR72aFJU4by+NEq4jVvrkh7MlGr1L2UOE/0kD23w4T+a4QaagD4zErYI4Mnz nT1OrxxMRYa4fZIoE74q2GTpslD3Vbw+xPqKP2ghFun2CAhpJntmvsFh+jeKAM69hzWZ HKcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=gkSAYMUUeoj+eF2MC+yCCyFv5i674GoIqfCANMk12Pk=; b=eFLgd68GRf8IvNdyPmxBxS+B/lBZvkWHDrj6aQoOOruaxzTGP+jINtgFDM/GTPOggQ +z0FEeNZl5g7AaV3F7tmyyCOuKgcLyN0Kzxo21LoBByVODhZFgFbE82RWya+CUeMIbCj 0ts6BlUONOUMOIn8ohw4XWd7pvB60QwHv49+pORqUYfGwjfOYaXK0QmxWC0GvDS+AUJJ vE+JlF3v0DCEueDC/eFLhcJt8Ve8g9rR4APu5UJUPJudAHmh+YoLRkojTx+y6Z7MuW8R uRRuOkfSH4BF1SjidLc0Jz7DDCOyQ23rLXWGXkTa34p4tw7fIg8CaC/7RrkbNm6Ea3gv Y3mw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cy15si10728960edb.10.2021.02.01.10.02.39; Mon, 01 Feb 2021 10:03:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231152AbhBASAT (ORCPT + 99 others); Mon, 1 Feb 2021 13:00:19 -0500 Received: from outgoing-auth-1.mit.edu ([18.9.28.11]:37786 "EHLO outgoing.mit.edu" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229555AbhBASAS (ORCPT ); Mon, 1 Feb 2021 13:00:18 -0500 Received: from cwcc.thunk.org (pool-72-74-133-215.bstnma.fios.verizon.net [72.74.133.215]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 111HxPfR028486 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 1 Feb 2021 12:59:25 -0500 Received: by cwcc.thunk.org (Postfix, from userid 15806) id 15A5B15C39D9; Mon, 1 Feb 2021 12:59:25 -0500 (EST) Date: Mon, 1 Feb 2021 12:59:25 -0500 From: "Theodore Ts'o" To: Lukas Bulwahn Cc: Greg KH , Dwaipayan Ray , Joe Perches , linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel Subject: Re: [Linux-kernel-mentees] Patches from the future - can checkpatch help? Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 01, 2021 at 05:50:45PM +0100, Lukas Bulwahn wrote: > > Dwaipayan, there are two ways: > - We build a bot listening to mailing lists and check. I like that > implementation idea for various other checks. > - Stephen Rothwell could include this as a check on linux-next and > inform the git author and committer. > > I am wondering though if that is worth the effort, three instances of > a wrong date among 1M commits seems to be very seldom and the harm of > that mistake is quite small as well. Another solution might be to ask the git developers if they would be willing to have "git am" print a warning if the date is sufficiently insane (say, more than 3 months in the past or present). One could also imagine a request that "git log" would have a new format where normally the author time is printed, but if it's sufficiently different from the commit time, the commit time is also printed in parenthesis. Or you could set up your git config so that "git log" uses --pretty=fuller by default, which prints both the author date and commit date. Like Lukas, I'm not really sure it's worth the effort, however. - Ted