Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 1 Feb 2021 14:34:53 -0500
From:   Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To:     Ben Widawsky <ben.widawsky@intel.com>
Cc:     linux-cxl@vger.kernel.org, linux-acpi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org,
        linux-pci@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
        Chris Browy <cbrowy@avery-design.com>,
        Christoph Hellwig <hch@infradead.org>,
        Dan Williams <dan.j.williams@intel.com>,
        Ira Weiny <ira.weiny@intel.com>,
        Jon Masters <jcm@jonmasters.org>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Rafael Wysocki <rafael.j.wysocki@intel.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        Vishal Verma <vishal.l.verma@intel.com>,
        daniel.lll@alibaba-inc.com,
        "John Groves (jgroves)" <jgroves@micron.com>,
        "Kelley, Sean V" <sean.v.kelley@intel.com>
Subject: Re: [PATCH 09/14] cxl/mem: Add a "RAW" send command
Message-ID: <20210201193453.GA308086@fedora>
References: <20210130002438.1872527-1-ben.widawsky@intel.com>
 <20210130002438.1872527-10-ben.widawsky@intel.com>
 <20210201182400.GK197521@fedora>
 <20210201192708.5cvyecbcdrwx77de@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210201192708.5cvyecbcdrwx77de@intel.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from fedora (209.6.208.110) by BL1PR13CA0386.namprd13.prod.outlook.com (2603:10b6:208:2c0::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.17 via Frontend Transport; Mon, 1 Feb 2021 19:34:56 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 9aa613e5-46ab-4bb4-feac-08d8c6e875e5
X-MS-TrafficTypeDiagnostic: BY5PR10MB3874:
X-Microsoft-Antispam-PRVS: <BY5PR10MB387442511B45F4C6FBB273B189B69@BY5PR10MB3874.namprd10.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1186;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: DdCKADQcLUM6lI1X9SLVI14uEln5pJ7nMk5gzUV/aCp058/oUXzCYEBQpdTyZkzptyGfO2767ciiDNqXdPzqvhU/NVaJXsEvdxzo7rIjV6ZsN8+aZMn54rraaPaC1Zujl8mebz93xplQPVbhIv7oiUZTFhBPG+EysCuep7EozPdqg0WkF2wkUnzLBo9A4ZoDADNxMXN6Bs3E0ls36qlg7da1sVVYCRuwjy+ueo2lKQoPl1m4hIq316tJnEdyllbfXTbKIGoxTf+knxqb37aNHcJwCCI8asp0t0FW1gIfnjDP8LU8amyCh23WDF5iB1tbkc/HoGhXiqbxAjOK1QWiQh0XoWNYncbMFvhytWsOp/H7LmZ7VT/UW4qf20xGZ64aA9fpUN32qInZEail35YlvU0DyBDvLgnTE/py+uaZRJ4CTbz11S3hOpOGzowxLG18iT/gKJH8nMk3BNm8CJBATQ/23h2cPUK5iPazbAYI84PJdVZukH5HYU2gnIoNioPqO8I9LdRliCJIYPffKAtpNA==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR10MB2999.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(346002)(376002)(396003)(136003)(366004)(6916009)(9576002)(6496006)(9686003)(54906003)(33656002)(8936002)(55016002)(7416002)(1076003)(478600001)(8676002)(6666004)(956004)(66556008)(66946007)(66476007)(186003)(52116002)(316002)(26005)(16526019)(2906002)(53546011)(4326008)(86362001)(33716001)(83380400001)(5660300002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?vSRmHiQN9lYwYXoZIwXeIDC7fbKunc6Cgw9tlpnRmb408QLTgLMyhUkgzqV0?=
 =?us-ascii?Q?f0FA0xaGa2sMIFXt2yKx7OmInu6SbW4Ns27JBSam9Ufp0jhGcsC2KTcL6BEw?=
 =?us-ascii?Q?en9uj298b99//gq6PUCF7GXjNAihrnp/IvVrd9B3hVIACjeC0332P3gduW9g?=
 =?us-ascii?Q?2LLz8tGqK1gnDpHr8oeQF+nZufPr4ZdQlkSQGtULKzEzwyN00knPwPSIq9Tu?=
 =?us-ascii?Q?Y5kKnjEdhqcTBem/6Lr1iTfqUsjn8Q4McIzND8n4iXZvYcK6/B87B4iNxXA0?=
 =?us-ascii?Q?Cfhn1NDhrDfJVCqUQ9pAQTrr4Ce9ir4Njsz8fhegW+Q20Xqn8GEVQg4c+/ml?=
 =?us-ascii?Q?wzA1T3XGeUVz+U8DZTuqMVhum7AIglhmZu3RjHjBESjulykVCtn2Y/ae7IzD?=
 =?us-ascii?Q?W0Hcj0SHKx1Z7odzS7I8WcGYJ/P3rlN5BtbHbpvo3M17ITxu5QEtmc6G3xR7?=
 =?us-ascii?Q?B2CD6cQY73mec87xckRWkSofnWFl8XLwQeSVB4rD2RDNW/3Woz0r8LHdqSPv?=
 =?us-ascii?Q?HyvMvsXrZahBouB9bvYN8uCkqVkW4f40EadGwSNcXOGmn+a4E5oQc5lk4CSp?=
 =?us-ascii?Q?g65o410gdhwBi3ul452ofOzx5SWkq50w5ax56EZ+6siE6Mrt/sp/1RBbEutf?=
 =?us-ascii?Q?HnouFbuoyWH3HHNYD7OhihkmVLP/uDxlntSNw3Trss7QCsBCxXd/IfC6ADJm?=
 =?us-ascii?Q?jWIqSLPqWu6ogsD613WXtHozj6dUnwLCakppeUQAG1na7WMyv0ErGpKspdgI?=
 =?us-ascii?Q?Rrl0j6fQ1EezJmUxhvvDA8ZkPhU+B0yuHDayxNkdiPU14IPJtpOT+SBBcCd8?=
 =?us-ascii?Q?YjqjE9xbpbLjc9xNog8mAE4ZGxZwNZMuinqqdllJh7Y55BOc7Agf6Ev/54yT?=
 =?us-ascii?Q?UZKiYw35NfVsOnJFi8ZciQNlsGsiswPerVbmkYcng+ondOKZIiu55ANoNF/r?=
 =?us-ascii?Q?v6IIJDvenvR6g4T2bIkylb71ymM2IlvsWAXmsfZ5bXqqESOusRUVUE9xvA/m?=
 =?us-ascii?Q?gwbGWE/uyWLM3GRBzLCqSfATVr61EjYfn39TraQYQcLthLdtJWy91y1w+6J2?=
 =?us-ascii?Q?HyVcaPvj?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9aa613e5-46ab-4bb4-feac-08d8c6e875e5
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2999.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2021 19:34:58.7653
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: HZsRb4NMKR6FUT4wyaBZeH3uv2YBt7kbqRTC5etjxVK65cwfLzBJOFsVmYYWutMwF6jhrI2QBD3GwPDzT85i6g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB3874
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9882 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 adultscore=0 suspectscore=0
 spamscore=0 mlxscore=0 malwarescore=0 mlxlogscore=999 phishscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2102010103
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9882 signatures=668683
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 mlxscore=0 priorityscore=1501 spamscore=0 impostorscore=0 clxscore=1015
 suspectscore=0 lowpriorityscore=0 phishscore=0 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000
 definitions=main-2102010103
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Feb 01, 2021 at 11:27:08AM -0800, Ben Widawsky wrote:
> On 21-02-01 13:24:00, Konrad Rzeszutek Wilk wrote:
> > On Fri, Jan 29, 2021 at 04:24:33PM -0800, Ben Widawsky wrote:
> > > The CXL memory device send interface will have a number of supported
> > > commands. The raw command is not such a command. Raw commands allow
> > > userspace to send a specified opcode to the underlying hardware and
> > > bypass all driver checks on the command. This is useful for a couple of
> > > usecases, mainly:
> > > 1. Undocumented vendor specific hardware commands
> > > 2. Prototyping new hardware commands not yet supported by the driver
> > 
> > This sounds like a recipe for ..
> > 
> > In case you really really want this may I recommend you do two things:
> > 
> > - Wrap this whole thing with #ifdef
> >   CONFIG_CXL_DEBUG_THIS_WILL_DESTROY_YOUR_LIFE
> > 
> >  (or something equivalant to make it clear this should never be
> >   enabled in production kernels).
> > 
> >  - Add a nice big fat printk in dmesg telling the user that they
> >    are creating a unstable parallel universe that will lead to their
> >    blood pressure going sky-high, or perhaps something more professional
> >    sounding.
> > 
> > - Rethink this. Do you really really want to encourage vendors
> >   to use this raw API instead of them using the proper APIs?
> 
> Again, the ideal is proper APIs. Barring that they get a WARN, and a taint if
> they use the raw commands.

Linux upstream is all about proper APIs. Just don't do this.
> 
> > 
> > > 
> > > While this all sounds very powerful it comes with a couple of caveats:
> > > 1. Bug reports using raw commands will not get the same level of
> > >    attention as bug reports using supported commands (via taint).
> > > 2. Supported commands will be rejected by the RAW command.
> > > 
> > > With this comes new debugfs knob to allow full access to your toes with
> > > your weapon of choice.
> > 
> > Problem is that debugfs is no longer "debug" but is enabled in
> > production kernel.
> 
> I don't see this as my problem. Again, they've been WARNed and tainted. If they

Right not your problem, nice.

But it is going to be the problem of vendor kernel engineers who don't have this luxury.

> want to do this, that's their business. They will be asked to reproduce without
> RAW if they file a bug report.


This is not how customers see the world. "If it is there, then it is
there to used right? Why else would someone give me the keys to this?"

Just kill this. Or better yet, make it a seperate set of patches for
folks developing code but not have it as part of this patchset.


>