Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4114643pxb; Mon, 1 Feb 2021 12:51:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJzHQZ1gpTeHpJ3zvhOzmET7DtR7DBU3GI81gvwF85iYEKmyZ4FMMyuonad4CfFDFpRJbxzo X-Received: by 2002:aa7:cfc3:: with SMTP id r3mr20840937edy.125.1612212693312; Mon, 01 Feb 2021 12:51:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612212693; cv=none; d=google.com; s=arc-20160816; b=i3TEa2UyDutVsPsAuQIvHeXdLpkK6qQlc/etba+rvKcOkHzdUfNQmH1o3xDLRRXSpM OgMTTU8+sIHeQtdfELygcefr5j/ryT3ML5srkfeIIRE8MsENm2k1DuNqHABbU2MkVNC1 S8ZmMXXbDt4B6ckAReS0+aw0NHkZiwWYcFoy2aSTYd7LcSMUQSuHlU1LoDyTaptseFn9 irCubPebgEj/Nh5g/pEiubW+aw93YM6Dnr+ZaAEjXx8LClHpDP8TkQpmuqb01iQrgGgk HIzMpvAkmJx7nhh9x8OllCqqGOhaqxyqP/E9Hg6y4QiyKuFykzaAV9sLB4ktw/U/yHkZ 46Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=dx+a2s/jKD+bm6v2qBtcJrio8FJGKN2zZWR18xESCUE=; b=TRszrodrbFkqLnGkk0ij38S9yxPPC4Y3uiMfR2D1TQTa/cRozMziRljT1piecjA4T4 99r+3xI3Sc3qMi7dPpVdEqy2HkirB9G4FH6lHzCIC12WZ3qeAZC79DZyRjvHNQ5zF8GO Z6Apy3oSV0bePDcwAEYJXEF0oByzxwbbduHct/gTcGr0SpD7GF5nZDijgWfuLvt2fLl/ qQiJ9i/YXFfqCq4rACF7TUwLxcZ5NjXl8u7PlVuyLbtVorKNPH+lpR9cdzrefMx4luv6 UixbtBKtHRPJZzuE6yfiK8eiWQY1lod/Bk5VEA8xbncUIBmoNlsqpvxaVm6VU9dkvqwD h0UA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=b4DrEK7T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y12si11730828edw.355.2021.02.01.12.51.07; Mon, 01 Feb 2021 12:51:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=b4DrEK7T; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229646AbhBAUte (ORCPT + 99 others); Mon, 1 Feb 2021 15:49:34 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:56123 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230273AbhBAUtc (ORCPT ); Mon, 1 Feb 2021 15:49:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612212486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dx+a2s/jKD+bm6v2qBtcJrio8FJGKN2zZWR18xESCUE=; b=b4DrEK7TIJCFrG2m/R85vxXAiX4EWmDVfvIqu/DnQCX48IWIss2cnjrHEmytkBBjX/y/ba WJNeIG7g4YyVutdPKiV7mgSleJX6DGg0KNBF1cKTOn0k/YvUdahTQ4n7V2TiD31Z/RyJSC gs2kL5Acb5zVjpHrD115/etUi9JPti4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-223-8dV7A_cmM-igASv8WzLAfg-1; Mon, 01 Feb 2021 15:48:02 -0500 X-MC-Unique: 8dV7A_cmM-igASv8WzLAfg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 89FEC10054FF; Mon, 1 Feb 2021 20:47:59 +0000 (UTC) Received: from omen.home.shazbot.org (ovpn-112-255.phx2.redhat.com [10.3.112.255]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2D80260877; Mon, 1 Feb 2021 20:47:58 +0000 (UTC) Date: Mon, 1 Feb 2021 13:47:57 -0700 From: Alex Williamson To: Matthew Rosato Cc: Cornelia Huck , Max Gurtovoy , jgg@nvidia.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, liranl@nvidia.com, oren@nvidia.com, tzahio@nvidia.com, leonro@nvidia.com, yarong@nvidia.com, aviadye@nvidia.com, shahafs@nvidia.com, artemp@nvidia.com, kwankhede@nvidia.com, ACurrid@nvidia.com, gmataev@nvidia.com, cjia@nvidia.com, yishaih@nvidia.com, aik@ozlabs.ru Subject: Re: [PATCH 6/9] vfio-pci/zdev: fix possible segmentation fault issue Message-ID: <20210201134757.375c91bf@omen.home.shazbot.org> In-Reply-To: <139adb14-f75a-25ef-06da-e87729c2ccf2@linux.ibm.com> References: <20210201162828.5938-1-mgurtovoy@nvidia.com> <20210201162828.5938-7-mgurtovoy@nvidia.com> <20210201175214.0dc3ba14.cohuck@redhat.com> <139adb14-f75a-25ef-06da-e87729c2ccf2@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Feb 2021 12:08:45 -0500 Matthew Rosato wrote: > On 2/1/21 11:52 AM, Cornelia Huck wrote: > > On Mon, 1 Feb 2021 16:28:25 +0000 > > Max Gurtovoy wrote: > > > >> In case allocation fails, we must behave correctly and exit with error. > >> > >> Signed-off-by: Max Gurtovoy > > > > Fixes: e6b817d4b821 ("vfio-pci/zdev: Add zPCI capabilities to VFIO_DEVICE_GET_INFO") > > > > Reviewed-by: Cornelia Huck > > > > I think this should go in independently of this series. > > > Agreed, makes sense to me -- thanks for finding. > > Reviewed-by: Matthew Rosato I can grab this one, and 5/9. Connie do you want to toss an R-b at 5/9? Thanks, Alex