Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4194996pxb; Mon, 1 Feb 2021 15:22:42 -0800 (PST) X-Google-Smtp-Source: ABdhPJyhJ6MN/LSLLcqkef0SC+OvrrBZxia3ZGu2h1qO07LCK/FZ3WE91GCA6dI54zept/6FuZtG X-Received: by 2002:a17:906:c0c9:: with SMTP id bn9mr5020470ejb.318.1612221762289; Mon, 01 Feb 2021 15:22:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612221762; cv=none; d=google.com; s=arc-20160816; b=VxaNu6GXTCdgvj9WP8vrAkn3qEZxYdQMgu+QkOic7oRDaSW5a/Rw2frKuWiy2Gntkd ib1mfN7vLfiMx9e9X026eGWe/D6pa5GPEaUAjdcNbUNZ8H5gYXTqAPR6cGSQ3zLKattm ZSo449VtJ7IG9aM4WcpUKX7TvYnRDY95TVKk1e3BCrMyLn1+LD6oDEK9jWKDwWPUWhIB hiiuuiSKkga9JQ8ZY/wkubi3i776pLfTSo8wxqHgATgdbOgY+EJWnbb6TWeCGBVg5+38 HMj4lBGGfvH1f91eN0s6UdBOwkAy7ymxkTCAqhAnZTkAlluE5ipIrlM2PoEUYQ3FuyxN 7raQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=oMytIsiiKh1Kw2eUbK2JHDcC0v94lmWEe431+tQfjjc=; b=odb2u/JF80g7cnqXTCFG2kO6GIshmbmLKb+IsTWg8QwECyxzM5yfAvyXPAZPASJ9Y8 t9u49sJLypXSxZck6VFbzXYLFG+vrMoWNdOZq/t6jy6oS2Qg++UIfMf7lew85suZmtYC MkJ3gQU2PNwUovRfj18zhHCzVgT1y2rHdTKMkFW57pNkuVCQynO66DoAmDBycBLy/ziF MrY9Ng12r4eWcElrzZKNuF9IfQtkf9bYCdg3P883Ymhymz9W2saQqg73EoiyBCvMXBxw bHe380JnA9LXYXBwPrzsG40CyCA/MkMD0SxlA9T018+AjQTWzpGyovdPLdZwQdNzZrBl k0bA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 1si1741817edv.597.2021.02.01.15.22.18; Mon, 01 Feb 2021 15:22:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230153AbhBAXS1 (ORCPT + 99 others); Mon, 1 Feb 2021 18:18:27 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:55809 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231183AbhBAXSQ (ORCPT ); Mon, 1 Feb 2021 18:18:16 -0500 X-Originating-IP: 86.202.109.140 Received: from localhost (lfbn-lyo-1-13-140.w86-202.abo.wanadoo.fr [86.202.109.140]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id B439D40003; Mon, 1 Feb 2021 23:17:25 +0000 (UTC) From: Alexandre Belloni To: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Cc: Alexandre Belloni , kernel@pengutronix.de, linux-kernel@vger.kernel.org, linux-i3c@lists.infradead.org, Greg Kroah-Hartman Subject: Re: [PATCH 1/2] i3c: Handle drivers without probe or remove callback Date: Tue, 2 Feb 2021 00:17:21 +0100 Message-Id: <161222143405.3432488.2548904901699225293.b4-ty@bootlin.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210128091048.17006-1-u.kleine-koenig@pengutronix.de> References: <20210128091048.17006-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Jan 2021 10:10:47 +0100, Uwe Kleine-König wrote: > A registered driver without a probe callback doesn't make sense, so > refuse to register such a driver. (Otherwise i3c_device_probe() yields a > NULL pointer exception.) > > A driver without remove is possible, e.g. when all resources are freed > using devm callbacks. So guard the call to driver->remove by a check > for being non-NULL. > > [...] Applied, thanks! [1/2] i3c: Handle drivers without probe or remove callback commit: 7456fea589c6ad3422b0c188871ae80e1d307737 [2/2] i3c: Make remove callback return void commit: dd9267034c0e364b49261c3e0070b863286d1242 Best regards, -- Alexandre Belloni