Date: Tue, 19 Sep 2006 23:20:16 -0700
From: Andrew Morton <akpm@osdl.org>
To: Alex Dubov <oakad@yahoo.com>
Cc: linux-kernel@vger.kernel.org, drzeus-list@drzeus.cx,
       rmk+lkml@arm.linux.org.uk
Subject: Re: [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader - source
Message-Id: <20060919232016.68a02e0e.akpm@osdl.org>
In-Reply-To: <20060920060212.7327.qmail@web36712.mail.mud.yahoo.com>
References: <20060920060212.7327.qmail@web36712.mail.mud.yahoo.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1118
Lines: 36

On Tue, 19 Sep 2006 23:02:11 -0700 (PDT)
Alex Dubov <oakad@yahoo.com> wrote:

> Driver for TI Flash Media card reader. At present, only MMC/SD
> cards are supported.

Could I ask where the information which permitted this (nice-looking) driver to
be written came from?


Trivia:

There's some whitespace damage in there.  Please search the diff for "^ "
and fix it up.

We indent the body of switch statements one tab stop less than this driver
does.

The driver has lots of really big inlined functions.  It's best to uninline
these.  If the function has a single callsite, gcc will inline it anyway. 
If the function has multiple callsites (now, or in the future), inlining it
is undesirable.

The driver has a lot of things like

	static inline void* tifm_get_drvdata(struct tifm_dev *dev)

whereas we prefer

	static inline void *tifm_get_drvdata(struct tifm_dev *dev)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/