Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: jTW3CDdWq0Eye8yu191Nttzm9TvsfZxxmU8Xam/IVx+SXW9ghKXlzymKnQJEDemLzAsoBAjo0p
 sChuqrHfJxBw==
IronPort-SDR: hF1RcR0g2YqnQc/kXdTtwjvLHy0Os+sVlwhWN82ZXYiR6/myuIBvKIqOPJ1qm1udb372V/Nk2e
 blUtrx4hsXXw==
From:   "Huang, Ying" <ying.huang@intel.com>
To:     Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/swap_state: Constify static struct attribute_group
References: <20210201233254.91809-1-rikard.falkeborn@gmail.com>
Date:   Tue, 02 Feb 2021 08:39:25 +0800
In-Reply-To: <20210201233254.91809-1-rikard.falkeborn@gmail.com> (Rikard
        Falkeborn's message of "Tue, 2 Feb 2021 00:32:54 +0100")
Message-ID: <8735yfl2v6.fsf@yhuang-dev.intel.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=ascii
Precedence: bulk

Rikard Falkeborn <rikard.falkeborn@gmail.com> writes:

> The only usage of swap_attr_group is to pass its address to
> sysfs_create_group() which takes a pointer to const attribute_group.
> Make it const to allow the compiler to put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>

Looks good to me.

Acked-by: "Huang, Ying" <ying.huang@intel.com>

> ---
>  mm/swap_state.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/swap_state.c b/mm/swap_state.c
> index d0d417efeecc..3cdee7b11da9 100644
> --- a/mm/swap_state.c
> +++ b/mm/swap_state.c
> @@ -901,7 +901,7 @@ static struct attribute *swap_attrs[] = {
>  	NULL,
>  };
>  
> -static struct attribute_group swap_attr_group = {
> +static const struct attribute_group swap_attr_group = {
>  	.attrs = swap_attrs,
>  };