Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Kevin Hilman <khilman@baylibre.com>
To:     Artem Lapkin <email2tema@gmail.com>, narmstrong@baylibre.com
Cc:     robh+dt@kernel.org, jbrunet@baylibre.com,
        christianshewitt@gmail.com, martin.blumenstingl@googlemail.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        art@khadas.com, nick@khadas.com, gouwa@khadas.com
Subject: Re: [PATCH] arm64: dts: meson-gx: remove wrong reserved BL31 memory
In-Reply-To: <20210130054022.2020338-1-art@khadas.com>
References: <20210130054022.2020338-1-art@khadas.com>
Date:   Mon, 01 Feb 2021 16:45:30 -0800
Message-ID: <7hy2g7guvp.fsf@baylibre.com>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

Artem Lapkin <email2tema@gmail.com> writes:

> Kernel boot fail on Khadas VIM1 VIM2 (meson GX) boards
> SOLUTION: just remove wrong mem reservation for 0x10000000 0x200000

You don't explain why it's wrong.

This region was added becasue there there are definitely GX devices which
have secure memory in this area, and this patch will break those devices.

>  ## Booting kernel from Legacy Image at 08080000 ...
>    Image Name:   kernel
>    Image Type:   AArch64 Linux Kernel Image (lzma compressed)
>    Data Size:    4657736 Bytes = 4.4 MiB
>    Load Address: 0f080000
>    Entry Point:  0f080000
>    Verifying Checksum ... OK
>  ## Flattened Device Tree blob at 08008000
>    Booting using the fdt blob at 0x8008000
>    Uncompressing Kernel Image
>  ERROR: reserving fdt memory region failed (addr=10000000 size=200000)
>    Loading Device Tree to 000000007bf23000, end 000000007bf2d3ce ... OK

I suspect if you change the load addresses used by u-boot to avoid this
region, you'll be able to boot just fine.

Kevin

>  Starting kernel ...
>
>  bl31 reboot reason: 0xd
>  bl31 reboot reason: 0x0
>  system cmd  1.
>
> Signed-off-by: Artem Lapkin <art@khadas.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-gx.dtsi | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> index 726b91d3a..71083b89d 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gx.dtsi
> @@ -32,12 +32,6 @@ hwrom_reserved: hwrom@0 {
>  			no-map;
>  		};
>  
> -		/* 2 MiB reserved for ARM Trusted Firmware (BL31) */
> -		secmon_reserved: secmon@10000000 {
> -			reg = <0x0 0x10000000 0x0 0x200000>;
> -			no-map;
> -		};
> -
>  		/* Alternate 3 MiB reserved for ARM Trusted Firmware (BL31) */
>  		secmon_reserved_alt: secmon@5000000 {
>  			reg = <0x0 0x05000000 0x0 0x300000>;
> -- 
> 2.25.1