Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp4247633pxb; Mon, 1 Feb 2021 17:07:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJwJL1PU4N+xut2AJOxWPfIEjUtB54oFuc4kfXPccYqajJcCHqhApnvkeYDefwXUyJbWQKiB X-Received: by 2002:aa7:c2c5:: with SMTP id m5mr11411499edp.250.1612228039328; Mon, 01 Feb 2021 17:07:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612228039; cv=none; d=google.com; s=arc-20160816; b=oHaP2OJ1KQCoSh3bMUQyLCYYsKIITXKYi7vHISvQderhox1F2z1bU+u4hLMjGwSoSv hwgwYSyJkoyzkSl34dgI2ZFpxi1g728MN6lFjIQxzA3GlV4crZJteUQpZUWko7o1GEXl UXSGCKmp3JUqTzDrSijqdt1Bf423wJ6h/hsDJJahMxIqL9g9zYJWfJhtfejmOchpq6U+ J+q5CmcZ0qppOPwRl70vwPrvE5DIAc83lI7G45r3uR3tZOQbKFuJ0IkkKxU42dLH/iDx YlU72QAoY7Km8VnCHevykJV/lNE9rJx9qF3OD0xVqMAz7Mvv0xIkddnTCKSX8IMiBuSx VpTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=Yp5ZBM0tP4Dwpg0I5sbDcelJh5PdP/5+mKylYESPe+w=; b=uzd87NxPsSWQAFMvSgm93OaMuLdUWxfdvMBugQuVvll3ECACjPS9Zqy6idcyfISE2B 34O78m5it9LUuhFYa9cgA9NNY4cLsZutu8XKr4DcMU2cjOiFrADVIFIeO4AHzszx2iAS GNy4k4btymyiCfsv2nYT4Bm65msZMvHsMoTCdzoZjyQNg3n4N6dDfxLGx0k3CfUxmaYD y8yu8Do8Gz0itzwFu9Sfo7QFyrQoVV5vmElHIPxCvA4xlLUpmHyz0JsL2Sco9rVX6d5p AkBOzpa5t6DdxkQwmzielUioLHXiw/fjrfeHQTWZXOwgYg/zhNSgVFaLjfbCEdPoJHDY p31g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dmNQyrpF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m19si10980115ejj.220.2021.02.01.17.06.52; Mon, 01 Feb 2021 17:07:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dmNQyrpF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229832AbhBBBCl (ORCPT + 99 others); Mon, 1 Feb 2021 20:02:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:48792 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbhBBBCl (ORCPT ); Mon, 1 Feb 2021 20:02:41 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id B9CF564EDE for ; Tue, 2 Feb 2021 01:02:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612227721; bh=FWrqTsy+RDdR4LtnRiT0C8ouxsmTWFMv+IV8m9NZyuo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=dmNQyrpFSmPJN7ludg46GbvNjRnYRCjSKD7nYX3tA0I09uM/N2LCHBEU44HVXb3ko MbiwNFh3OMeNupg73pPk3F0/Tzsr6GCyPz+jC1F7RxHZ6ijuEMjPgz8w6XJRE4wE8l RxxOILvfnIS0Wx/3wxsdbnTxF3U+YRsizKnKW8Gw/boM9Mat4ncBdGy4Si7+q4B0M7 2oWZRUMwr9nC3igQlFwxEBRUGNkh2QPOxVib5VCW6rGE5gAGrN001k1DMz5W/fCpJd sGZfeiDMJF8RXA/QlarxeYsAgjQl8oSPJ1liFjy3F9mNYQwiFSODSErfI8OhLpyLmB ypuZOQzYo8q0A== Received: by mail-ej1-f49.google.com with SMTP id p20so7969272ejb.6 for ; Mon, 01 Feb 2021 17:02:00 -0800 (PST) X-Gm-Message-State: AOAM531ANtNPjX+ntOoOYy2VWE95djJuxV2ogmm12wuFeloZYffW97Ox wQIq2WHCadZ1MsVyI9Ou4kcHtXxnzM0w41Ie2dLDSQ== X-Received: by 2002:a17:906:c824:: with SMTP id dd4mr18960828ejb.253.1612227719358; Mon, 01 Feb 2021 17:01:59 -0800 (PST) MIME-Version: 1.0 References: <5b0ad34afeeee15032393367b0945a5032903162.1612113550.git.luto@kernel.org> <20210201091418.GC3229269@infradead.org> In-Reply-To: <20210201091418.GC3229269@infradead.org> From: Andy Lutomirski Date: Mon, 1 Feb 2021 17:01:48 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 09/11] x86/fault: Rename no_context() to kernelmode_fixup_or_oops() To: Christoph Hellwig Cc: Andy Lutomirski , X86 ML , LKML , Dave Hansen , Alexei Starovoitov , Daniel Borkmann , Yonghong Song , Masami Hiramatsu , Peter Zijlstra Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 1, 2021 at 1:14 AM Christoph Hellwig wrote: > > On Sun, Jan 31, 2021 at 09:24:40AM -0800, Andy Lutomirski wrote: > > + kernelmode_fixup_or_oops(regs, error_code, address, pkey, si_code); > > > if (!user_mode(regs)) { > > - no_context(regs, error_code, address, SIGBUS, BUS_ADRERR); > > + kernelmode_fixup_or_oops(regs, error_code, address, SIGBUS, BUS_ADRERR); > > These overly long lines are a little annoying.. It's not that long, and Linus seems to think you should make your terminal wider :) --Andy