Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To:     =?iso-8859-1?Q?Pali_Roh=E1r?= <pali@kernel.org>
CC:     Mathias Nyman <mathias.nyman@linux.intel.com>,
        Peter Chen <peter.chen@nxp.com>,
        Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jun Li <jun.li@nxp.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] usb: host: xhci-plat: fix support for
 XHCI_SKIP_PHY_INIT quirk
Thread-Topic: [PATCH v2] usb: host: xhci-plat: fix support for
 XHCI_SKIP_PHY_INIT quirk
Thread-Index: AQHW2UemNB5r1TTib029sWHXFxYWcaoFwTaAgCCRuICAAoBBAIAPxLcAgADnsXCAAFLOAIAJ1DCAgACo3vA=
Date:   Tue, 2 Feb 2021 01:17:19 +0000
Message-ID: <TY2PR01MB36929302951B0A782A00F6FCD8B59@TY2PR01MB3692.jpnprd01.prod.outlook.com>
References: <20201221150903.26630-1-pali@kernel.org>
 <20201223161847.10811-1-pali@kernel.org>
 <20201224055836.GB27629@b29397-desktop>
 <20210113232057.niqamgsqlaw7gojw@pali>
 <88b48c61-65e4-cc24-d90d-5fba92f05f27@linux.intel.com>
 <20210125142028.th4sscs27arhihm2@pali>
 <TY2PR01MB369295E3D3BF6D5700EC50CCD8BC0@TY2PR01MB3692.jpnprd01.prod.outlook.com>
 <20210126090606.svpamobnrbdxyhgg@pali> <20210201151153.zhk4tq5a3irnkahd@pali>
In-Reply-To: <20210201151153.zhk4tq5a3irnkahd@pali>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4dd6055e-16b6-4bf6-c937-08d8c718493f
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2021 01:17:19.4035
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6eMZuFC25EK/L1Gx8lgf1WvF2rPQ1ItI0Ibi7w67JNXiwsv6Kw4UlCHMRH9S015CgBomXZxhHE8fwfr8swrvvJvXAjddxnFJvzDWtxYacj8YSB2+8V46SGISkBSoDQi2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB5741
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Pali Roh=E1r, Sent: Tuesday, February 2, 2021 12:12 AM
> On Tuesday 26 January 2021 10:06:06 Pali Roh=E1r wrote:
> > On Tuesday 26 January 2021 04:27:37 Yoshihiro Shimoda wrote:
> > > Hi Pali,
> > > > > I can see the benefit in this.
> > > > > In the xhci-plat case usb_create_hcd and usb_add_hcd are separate=
 steps, and
> > > > > we could both copy the xhci_plat_priv .quirks and run the .init_q=
urks before
> > > > > adding the hcd.
> > > > > I guess the current way is inherited from pci case where the earl=
iest place
> > > > > to do this after hcd is created is the hcd->driver->reset callbac=
k (which is
> > > > > set to xhci_pci_setup() or xhci_plat_setup()).
> > > > >
> > > > > xhci-rcar.c is using the .init_quirk to load firmware, we need to=
 check with
> > > > > them if this change is ok. (added Yoshihiro Shimoda to cc)
> > > >
> > > > Yoshihiro, is this change OK?
> > > >
> > > > Can we move forward? I really need to now how to handle regression =
in
> > > > xhci-mvebu driver. And one option is with this patch...
> > >
> > > Thank you for asking me about this topic. I tested the patch, but unf=
ortunately,
> > > this patch is possible to break a rcar platform because a phy initial=
ization is
> > > needed before the firmware loading if the platform uses the phy. (Not=
e that
> > > upstream code (salvator-common.dtsi) doesn't use the phy for xhci. Bu=
t,
> > > if we use the phy on other board with this patch, the xhci will not w=
ork.)
> > >
> > > So, I think we need to add a new function pointer for your case.
> >
> > Ok, thank you for testing! I will try to come up with other solution to
> > mentioned mvebu-xhci issue.
>=20
> Hello! New version of this patch is in following thread, please review it=
:
> "[PATCH v2] usb: host: xhci: mvebu: make USB 3.0 PHY optional for Armada =
3720"

Thanks! I'll review it.

Best regards,
Yoshihiro Shimoda