Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210127172500.13356-1-andre.przywara@arm.com>
 <20210127172500.13356-7-andre.przywara@arm.com> <20210128101544.yyvrguk2jlgr4uwo@gilmour>
In-Reply-To: <20210128101544.yyvrguk2jlgr4uwo@gilmour>
From:   Chen-Yu Tsai <wens@csie.org>
Date:   Tue, 2 Feb 2021 15:58:38 +0800
Message-ID: <CAGb2v65_Zvi_ydb0cx4YYu3v11ns57fa+PT-+qtdKn+N-fLugg@mail.gmail.com>
Subject: Re: [linux-sunxi] Re: [PATCH v5 06/20] mfd: axp20x: Allow AXP chips
 without interrupt lines
To:     Andre Przywara <andre.przywara@arm.com>,
        Lee Jones <lee.jones@linaro.org>
Cc:     Maxime Ripard <maxime@cerno.tech>,
        Jernej Skrabec <jernej.skrabec@siol.net>,
        Samuel Holland <samuel@sholland.org>,
        Icenowy Zheng <icenowy@aosc.io>, Rob Herring <robh@kernel.org>,
        =?UTF-8?B?Q2zDqW1lbnQgUMOpcm9u?= <peron.clem@gmail.com>,
        Shuosheng Huang <huangshuosheng@allwinnertech.com>,
        Yangtao Li <tiny.windzz@gmail.com>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        linux-sunxi <linux-sunxi@googlegroups.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jan 28, 2021 at 6:15 PM Maxime Ripard <maxime@cerno.tech> wrote:
>
> On Wed, Jan 27, 2021 at 05:24:46PM +0000, Andre Przywara wrote:
> > Currently the AXP chip requires to have its IRQ line connected to some
> > interrupt controller, and will fail probing when this is not the case.
> >
> > On a new Allwinner SoC (H616) there is no NMI pin anymore, and at
> > least one board does not connect the AXP's IRQ pin to anything else,
> > so the interrupt functionality of the AXP chip is simply not available.
> >
> > Check whether the interrupt line number returned by the platform code is
> > valid, before trying to register the irqchip. If not, we skip this
> > registration, to avoid the driver to bail out completely.
> >
> > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
>
> Acked-by: Maxime Ripard <mripard@kernel.org>

Acked-by: Chen-Yu Tsai <wens@csie.org>