Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Feb 2021 08:58:59 +0100
From:   Cornelia Huck <cohuck@redhat.com>
To:     Alex Williamson <alex.williamson@redhat.com>
Cc:     Matthew Rosato <mjrosato@linux.ibm.com>,
        Max Gurtovoy <mgurtovoy@nvidia.com>, jgg@nvidia.com,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        liranl@nvidia.com, oren@nvidia.com, tzahio@nvidia.com,
        leonro@nvidia.com, yarong@nvidia.com, aviadye@nvidia.com,
        shahafs@nvidia.com, artemp@nvidia.com, kwankhede@nvidia.com,
        ACurrid@nvidia.com, gmataev@nvidia.com, cjia@nvidia.com,
        yishaih@nvidia.com, aik@ozlabs.ru
Subject: Re: [PATCH 6/9] vfio-pci/zdev: fix possible segmentation fault
 issue
Message-ID: <20210202085859.12c09b6d.cohuck@redhat.com>
In-Reply-To: <20210201134757.375c91bf@omen.home.shazbot.org>
References: <20210201162828.5938-1-mgurtovoy@nvidia.com>
        <20210201162828.5938-7-mgurtovoy@nvidia.com>
        <20210201175214.0dc3ba14.cohuck@redhat.com>
        <139adb14-f75a-25ef-06da-e87729c2ccf2@linux.ibm.com>
        <20210201134757.375c91bf@omen.home.shazbot.org>
Organization: Red Hat GmbH
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 1 Feb 2021 13:47:57 -0700
Alex Williamson <alex.williamson@redhat.com> wrote:

> On Mon, 1 Feb 2021 12:08:45 -0500
> Matthew Rosato <mjrosato@linux.ibm.com> wrote:
> 
> > On 2/1/21 11:52 AM, Cornelia Huck wrote:  
> > > On Mon, 1 Feb 2021 16:28:25 +0000
> > > Max Gurtovoy <mgurtovoy@nvidia.com> wrote:
> > >     
> > >> In case allocation fails, we must behave correctly and exit with error.
> > >>
> > >> Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>    
> > > 
> > > Fixes: e6b817d4b821 ("vfio-pci/zdev: Add zPCI capabilities to VFIO_DEVICE_GET_INFO")
> > > 
> > > Reviewed-by: Cornelia Huck <cohuck@redhat.com>
> > > 
> > > I think this should go in independently of this series. >    
> > 
> > Agreed, makes sense to me -- thanks for finding.
> > 
> > Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>  
> 
> I can grab this one, and 5/9.  Connie do you want to toss an R-b at
> 5/9?  Thanks,
> 
> Alex

Yes, makes sense to grab these two. R-b added.