Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210202051829.2127214-1-daeho43@gmail.com> <ef27f0cc-87b6-cea1-31a6-f2837d6a673c@huawei.com>
In-Reply-To: <ef27f0cc-87b6-cea1-31a6-f2837d6a673c@huawei.com>
From:   Daeho Jeong <daeho43@gmail.com>
Date:   Tue, 2 Feb 2021 17:02:34 +0900
Message-ID: <CACOAw_wGY1CNXZ9QoLB1t0800Wyjv1_P9iuqk4SOKjT-oUQamw@mail.gmail.com>
Subject: Re: [f2fs-dev] [PATCH v2] f2fs: rename checkpoint=merge mount option
 to checkpoint_merge
To:     Chao Yu <yuchao0@huawei.com>
Cc:     linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net, kernel-team@android.com,
        Daeho Jeong <daehojeong@google.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

I chose the same step with "flush_merge", because it doesn't have
"noflush_merge".
Do you think we need that for both, "noflush_merge" and "nocheckpoint_merge=
"?

I thought we needed to give some time to make this be turned on by
default. It might be a little radical. :)

What do you think?

2021=EB=85=84 2=EC=9B=94 2=EC=9D=BC (=ED=99=94) =EC=98=A4=ED=9B=84 4:40, Ch=
ao Yu <yuchao0@huawei.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> On 2021/2/2 13:18, Daeho Jeong wrote:
> > From: Daeho Jeong <daehojeong@google.com>
> >
> > As checkpoint=3Dmerge comes in, mount option setting related to checkpo=
int
> > had been mixed up and it became hard to understand. So, I separated
> > this option from "checkpoint=3D" and made another mount option
> > "checkpoint_merge" for this.
> >
> > Signed-off-by: Daeho Jeong <daehojeong@google.com>
> > ---
> > v2: renamed "checkpoint=3Dmerge" to "checkpoint_merge"
> > ---
> >   Documentation/filesystems/f2fs.rst |  6 +++---
> >   fs/f2fs/super.c                    | 26 ++++++++++++++------------
> >   2 files changed, 17 insertions(+), 15 deletions(-)
> >
> > diff --git a/Documentation/filesystems/f2fs.rst b/Documentation/filesys=
tems/f2fs.rst
> > index d0ead45dc706..475994ed8b15 100644
> > --- a/Documentation/filesystems/f2fs.rst
> > +++ b/Documentation/filesystems/f2fs.rst
> > @@ -247,9 +247,9 @@ checkpoint=3D%s[:%u[%]]      Set to "disable" to tu=
rn off checkpointing. Set to "enabl
> >                        hide up to all remaining free space. The actual =
space that
> >                        would be unusable can be viewed at /sys/fs/f2fs/=
<disk>/unusable
> >                        This space is reclaimed once checkpoint=3Denable=
.
> > -                      Here is another option "merge", which creates a =
kernel daemon
> > -                      and makes it to merge concurrent checkpoint requ=
ests as much
> > -                      as possible to eliminate redundant checkpoint is=
sues. Plus,
> > +checkpoint_merge      When checkpoint is enabled, this can be used to =
create a kernel
> > +                      daemon and make it to merge concurrent checkpoin=
t requests as
> > +                      much as possible to eliminate redundant checkpoi=
nt issues. Plus,
> >                        we can eliminate the sluggish issue caused by sl=
ow checkpoint
> >                        operation when the checkpoint is done in a proce=
ss context in
> >                        a cgroup having low i/o budget and cpu shares. T=
o make this
> > diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> > index 56696f6cfa86..d8603e6c4916 100644
> > --- a/fs/f2fs/super.c
> > +++ b/fs/f2fs/super.c
> > @@ -145,6 +145,7 @@ enum {
> >       Opt_checkpoint_disable_cap_perc,
> >       Opt_checkpoint_enable,
> >       Opt_checkpoint_merge,
> > +     Opt_nocheckpoint_merge,
> >       Opt_compress_algorithm,
> >       Opt_compress_log_size,
> >       Opt_compress_extension,
> > @@ -215,7 +216,8 @@ static match_table_t f2fs_tokens =3D {
> >       {Opt_checkpoint_disable_cap, "checkpoint=3Ddisable:%u"},
> >       {Opt_checkpoint_disable_cap_perc, "checkpoint=3Ddisable:%u%%"},
> >       {Opt_checkpoint_enable, "checkpoint=3Denable"},
> > -     {Opt_checkpoint_merge, "checkpoint=3Dmerge"},
> > +     {Opt_checkpoint_merge, "checkpoint_merge"},
> > +     {Opt_nocheckpoint_merge, "nocheckpoint_merge"},
> >       {Opt_compress_algorithm, "compress_algorithm=3D%s"},
> >       {Opt_compress_log_size, "compress_log_size=3D%u"},
> >       {Opt_compress_extension, "compress_extension=3D%s"},
> > @@ -946,6 +948,9 @@ static int parse_options(struct super_block *sb, ch=
ar *options, bool is_remount)
> >               case Opt_checkpoint_merge:
> >                       set_opt(sbi, MERGE_CHECKPOINT);
> >                       break;
> > +             case Opt_nocheckpoint_merge:
> > +                     clear_opt(sbi, MERGE_CHECKPOINT);
> > +                     break;
> >   #ifdef CONFIG_F2FS_FS_COMPRESSION
> >               case Opt_compress_algorithm:
> >                       if (!f2fs_sb_has_compression(sbi)) {
> > @@ -1142,12 +1147,6 @@ static int parse_options(struct super_block *sb,=
 char *options, bool is_remount)
> >               return -EINVAL;
> >       }
> >
> > -     if (test_opt(sbi, DISABLE_CHECKPOINT) &&
> > -                     test_opt(sbi, MERGE_CHECKPOINT)) {
> > -             f2fs_err(sbi, "checkpoint=3Dmerge cannot be used with che=
ckpoint=3Ddisable\n");
> > -             return -EINVAL;
> > -     }
> > -
> >       /* Not pass down write hints if the number of active logs is less=
er
> >        * than NR_CURSEG_PERSIST_TYPE.
> >        */
> > @@ -1782,7 +1781,7 @@ static int f2fs_show_options(struct seq_file *seq=
, struct dentry *root)
> >               seq_printf(seq, ",checkpoint=3Ddisable:%u",
> >                               F2FS_OPTION(sbi).unusable_cap);
> >       if (test_opt(sbi, MERGE_CHECKPOINT))
> > -             seq_puts(seq, ",checkpoint=3Dmerge");
> > +             seq_puts(seq, ",checkpoint_merge");
>
> Other noxxx options will be shown in show_options(), how about following =
them?
>
> >       if (F2FS_OPTION(sbi).fsync_mode =3D=3D FSYNC_MODE_POSIX)
> >               seq_printf(seq, ",fsync_mode=3D%s", "posix");
> >       else if (F2FS_OPTION(sbi).fsync_mode =3D=3D FSYNC_MODE_STRICT)
> > @@ -1827,6 +1826,7 @@ static void default_options(struct f2fs_sb_info *=
sbi)
> >       sbi->sb->s_flags |=3D SB_LAZYTIME;
> >       set_opt(sbi, FLUSH_MERGE);
> >       set_opt(sbi, DISCARD);
> > +     clear_opt(sbi, MERGE_CHECKPOINT);
>
> Why should we clear checkpoint_merge option in default_options()?
>
> Thanks,
>
> >       if (f2fs_sb_has_blkzoned(sbi))
> >               F2FS_OPTION(sbi).fs_mode =3D FS_MODE_LFS;
> >       else
> > @@ -2066,9 +2066,8 @@ static int f2fs_remount(struct super_block *sb, i=
nt *flags, char *data)
> >               }
> >       }
> >
> > -     if (!test_opt(sbi, MERGE_CHECKPOINT)) {
> > -             f2fs_stop_ckpt_thread(sbi);
> > -     } else {
> > +     if (!test_opt(sbi, DISABLE_CHECKPOINT) &&
> > +                     test_opt(sbi, MERGE_CHECKPOINT)) {
> >               err =3D f2fs_start_ckpt_thread(sbi);
> >               if (err) {
> >                       f2fs_err(sbi,
> > @@ -2076,6 +2075,8 @@ static int f2fs_remount(struct super_block *sb, i=
nt *flags, char *data)
> >                           err);
> >                       goto restore_gc;
> >               }
> > +     } else {
> > +             f2fs_stop_ckpt_thread(sbi);
> >       }
> >
> >       /*
> > @@ -3831,7 +3832,8 @@ static int f2fs_fill_super(struct super_block *sb=
, void *data, int silent)
> >
> >       /* setup checkpoint request control and start checkpoint issue th=
read */
> >       f2fs_init_ckpt_req_control(sbi);
> > -     if (test_opt(sbi, MERGE_CHECKPOINT)) {
> > +     if (!test_opt(sbi, DISABLE_CHECKPOINT) &&
> > +                     test_opt(sbi, MERGE_CHECKPOINT)) {
> >               err =3D f2fs_start_ckpt_thread(sbi);
> >               if (err) {
> >                       f2fs_err(sbi,
> >