Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: TjiajcQu8hiWbokg6NvcsRgCRx6oi9x9GDItJ8GtCMocRS04jbVY/rH6YAXORY8cbzOuZegX2b
 XMABRm7vjbuw==
IronPort-SDR: WAnMADibO6TaXQ29FfB/fxgl6lF2DbEN/KLanN7lHaF/PIxH6zZ25JwiYMxZX4I1aInMm5UsN+
 y3mv8IKyRBig==
Date:   Tue, 2 Feb 2021 10:21:33 +0200
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Badhri Jagan Sridharan <badhri@google.com>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Kyle Tso <kyletso@google.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] usb: typec: tcpm: Handle vbus shutoff when in source
 mode
Message-ID: <20210202082133.GB1433721@kuha.fi.intel.com>
References: <20210201100212.49863-1-badhri@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210201100212.49863-1-badhri@google.com>
Precedence: bulk

On Mon, Feb 01, 2021 at 02:02:12AM -0800, Badhri Jagan Sridharan wrote:
> While in source mode, vbus could be shutoff by protections
> circuits. TCPM does not move back to toggling state to
> re-initiate connection. Fix this by moving to SRC_UNATTACHED
> state when vbus shuts off while in source mode.
> 
> Signed-off-by: Badhri Jagan Sridharan <badhri@google.com>

Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>  drivers/usb/typec/tcpm/tcpm.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index 0afd8ef692e8..ff0732c12b8a 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -4897,6 +4897,17 @@ static void _tcpm_pd_vbus_off(struct tcpm_port *port)
>  		/* Do nothing, waiting for sink detection */
>  		break;
>  
> +	case SRC_STARTUP:
> +	case SRC_SEND_CAPABILITIES:
> +	case SRC_SEND_CAPABILITIES_TIMEOUT:
> +	case SRC_NEGOTIATE_CAPABILITIES:
> +	case SRC_TRANSITION_SUPPLY:
> +	case SRC_READY:
> +	case SRC_WAIT_NEW_CAPABILITIES:
> +		/* Force to unattached state to re-initiate connection */
> +		tcpm_set_state(port, SRC_UNATTACHED, 0);
> +		break;
> +
>  	case PORT_RESET:
>  		/*
>  		 * State set back to default mode once the timer completes.
> -- 
> 2.30.0.365.g02bc693789-goog

thanks,

-- 
heikki