Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750870AbWITJic (ORCPT ); Wed, 20 Sep 2006 05:38:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750876AbWITJic (ORCPT ); Wed, 20 Sep 2006 05:38:32 -0400 Received: from nrg.cs.usm.my ([202.170.56.22]:31370 "EHLO nrg.cs.usm.my") by vger.kernel.org with ESMTP id S1750864AbWITJib (ORCPT ); Wed, 20 Sep 2006 05:38:31 -0400 Message-ID: <54547.10.207.160.203.1158745098.squirrel@10.207.160.104> In-Reply-To: <1158344303.5233.50.camel@localhost> References: <20060906224631.999046890@quad.kroah.org> <20060906225740.GD15922@kroah.com> <45016909.4080908@linuxtv.org> <20060908172944.GA1254@suse.de> <450AD0CA.7080800@linuxtv.org> <1158338161.5233.47.camel@localhost> <450AEBFD.2070106@linuxtv.org> <1158344303.5233.50.camel@localhost> Date: Wed, 20 Sep 2006 17:38:18 +0800 (MYT) Subject: Re: [patch 29/37] dvb-core: Proper handling ULE SNDU length of 0 From: "Ang Way Chuang" To: "Marcel Holtmann" Cc: "Michael Krufky" , "Greg KH" , linux-kernel@vger.kernel.org, stable@kernel.org, "Justin Forbes" , "Zwane Mwaikambo" , "Theodore Ts'o" , "Randy Dunlap" , "Dave Jones" , "Chuck Wolber" , "Chris Wedgwood" , torvalds@osdl.org, akpm@osdl.org, alan@lxorguk.ukuu.org.uk, "Ang Way Chuang" , "v4l-dvb maintainer list" , "Marcel Siegert" User-Agent: SquirrelMail/1.4.6-4.fc2.1.legacy MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1920 Lines: 52 Hi Marcel, Marcel Holtmann wrote: > Hi Michael, > >> >>>> Can we hold off on this until the 2.6.17.13 review cycle? This patch >> >>>> has not been sent to the linux-dvb mailing list, it has not been >> >>>> reviewed or tested except for the Author and Marcel. >> >>> Yes, I've now moved it, thanks. >> >> Marcel Siegert and I spoke about this today -- We are doing things a >> >> bit differently for 2.6.18 and later, but this patch is appropriate for >> >> 2.6.17.y >> > >> > so this means it is fixed in 2.6.18 or is it still vulnerable. If it is >> > still vulnerable, then we need a fix. And we need it now. >> >> 2.6.18 should not be vulnerable. See the following changeset in Linus' >> tree: >> >> http://www.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blobdiff;h=8859ab74f0fe4c65c8e75b9350a2a0b138615525;hp=9fd87521a1639bd3dae51dcdce48545614d41a85;hb=18232ca61b4c73b849850200a5e6ec40517f35ab;f=drivers/media/dvb/dvb-core/dvb_net.c >> >> Quoting MWS from irc: >> >> if the len is smaller than 4 or if dbit set smaller than 4+ealen, just >> get rid of that packet and interpret as error. the 2.6.18 is not letting >> them through if they are < sizeof(5), so 4 byte packets would be ignored. > > I saw the changeset in the current 2.6.18-rc kernel and this was the > reason for me asking. I don't have the hardware to reproduce this, but > if you say that the final 2.6.18 kernel will not be vulnerable, then I > take your word for it. > > Regards > > Marcel > > > I've tested 2.6.18-rc7 and it seems there is no problem with the case where dbit is not set. It should not be vulnerable. Thanks Regards, Ang Way Chuang -- May you be well and happy. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/