Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210201133421.408508-1-kyletso@google.com> <20210201133421.408508-2-kyletso@google.com>
 <20210201153542.GH2465@kuha.fi.intel.com>
In-Reply-To: <20210201153542.GH2465@kuha.fi.intel.com>
From:   Kyle Tso <kyletso@google.com>
Date:   Tue, 2 Feb 2021 16:37:00 +0800
Message-ID: <CAGZ6i=0Csdfy0Z-608HsX1YLBPiAz7qindF5SdTXv0yoNu7DYA@mail.gmail.com>
Subject: Re: [PATCH v3 1/3] usb: typec: Determine common SVDM Versions
To:     Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc:     Guenter Roeck <linux@roeck-us.net>,
        Greg KH <gregkh@linuxfoundation.org>,
        Hans de Goede <hdegoede@redhat.com>, robh+dt@kernel.org,
        Badhri Jagan Sridharan <badhri@google.com>,
        USB <linux-usb@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>, devicetree@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Feb 1, 2021 at 11:35 PM Heikki Krogerus
<heikki.krogerus@linux.intel.com> wrote:
>
> On Mon, Feb 01, 2021 at 09:34:19PM +0800, Kyle Tso wrote:
> > PD Spec Revision 3.0 Version 2.0 + ECNs 2020-12-10
> >   6.4.4.2.3 Structured VDM Version
> >   "The Structured VDM Version field of the Discover Identity Command
> >   sent and received during VDM discovery Shall be used to determine the
> >   lowest common Structured VDM Version supported by the Port Partners or
> >   Cable Plug and Shall continue to operate using this Specification
> >   Revision until they are Detached."
> >
> > Also clear the fields newly defined in SVDM version 2.0 for
> > compatibilities. And fix some VDO definitions changed in the Spec.
> >
> > Signed-off-by: Kyle Tso <kyletso@google.com>
> > ---
> > Changes since v2:
> > - rename the variable and the functions (remove the text "common")
> > - remove the macro
> >
> >  drivers/usb/typec/altmodes/displayport.c |   8 +-
> >  drivers/usb/typec/class.c                |  21 +-
> >  drivers/usb/typec/tcpm/tcpm.c            |  47 +++-
> >  drivers/usb/typec/ucsi/displayport.c     |  12 +-
> >  drivers/usb/typec/ucsi/ucsi.c            |   2 +
> >  include/linux/usb/pd_vdo.h               | 315 +++++++++++++++++------
> >  include/linux/usb/typec.h                |  10 +
> >  7 files changed, 326 insertions(+), 89 deletions(-)
>
> I think there is some room to split this one at least a little. The
> changes to the class (so drivers/usb/typec/class.c and
> include/linux/usb/typec.h) could be introduced separately at least.
>
> So I see there are two changes in this patch. You are modifying the
> class, and then there are the updated PD definitions. Both should be
> introduced in separate patches IMO. I think also each driver (so
> ucsi.c and tcpm.c) can handle the changes to the class in its own
> patch. The modifications to the PD definitions and updated VDO() and
> so on can be handled in a single patch I guess.
>
I will separate this patch to different ones.

thanks,
Kyle

>
> thanks,
>
> --
> heikki