Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 6nrJlgn7N6M7x9RI1xhKeny1Tvomx1NzOu3PJW1n7MyzcX2jA2g/aQpwZwW6U4LkW/TVMW0gUm
 vffgUn18rkGg==
IronPort-SDR: avySLk35+vqkXKb0tLytWPJUIw3mv1QodxFp/NK64d9ys5wl02AaVN4LCnQRDVWT4oVJNVOvXN
 iHxc7JNzjzkg==
From:   "C, Udhayakumar" <udhayakumar.c@intel.com>
To:     Rob Herring <robh@kernel.org>,
        "mgross@linux.intel.com" <mgross@linux.intel.com>
CC:     "jassisinghbrar@gmail.com" <jassisinghbrar@gmail.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "dragan.cvetic@xilinx.com" <dragan.cvetic@xilinx.com>,
        "palmerdabbelt@google.com" <palmerdabbelt@google.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "damien.lemoal@wdc.com" <damien.lemoal@wdc.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "peng.fan@nxp.com" <peng.fan@nxp.com>, "bp@suse.de" <bp@suse.de>,
        "markgross@kernel.org" <markgross@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: RE: [PATCH v4 26/34] dt-bindings: misc: intel_tsens: Add tsens
 thermal bindings documentation
Thread-Topic: [PATCH v4 26/34] dt-bindings: misc: intel_tsens: Add tsens
 thermal bindings documentation
Thread-Index: AQHW9q6lj3FUU2CjtU+y+miynl+YGKpAa+8AgAQkwLA=
Date:   Tue, 2 Feb 2021 08:47:46 +0000
Message-ID: <BL0PR11MB323427EEAE8176C0033178A1E2B59@BL0PR11MB3234.namprd11.prod.outlook.com>
References: <20210130022124.65083-1-mgross@linux.intel.com>
 <20210130022124.65083-62-mgross@linux.intel.com>
 <1612027420.847882.1419429.nullmailer@robh.at.kernel.org>
In-Reply-To: <1612027420.847882.1419429.nullmailer@robh.at.kernel.org>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-reaction: no-action
dlp-version: 11.5.1.3
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: af562de2-a38b-4746-e3d4-08d8c75736ad
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2021 08:47:46.5713
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JEDU9ji9UOb7j+ChM5QASF8ULNUff/QyxhljHx+SDtAQmdAgF2kWcEtkHld3RsBkoyGFJCAX9ykLIbzzcfaEFg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4415
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Fri, 29 Jan 2021 18:21:16 -0800, mgross@linux.intel.com wrote:
> > From: "C, Udhayakumar" <udhayakumar.c@intel.com>
> >
> > Add device tree bindings for local host thermal sensors Intel Edge.AI
> > Computer Vision platforms.
> >
> > The tsens module enables reading of on chip sensors present in the
> > Intel Bay series SoC. In the tsens module various junction temperature
> > and SoC temperature are reported using thermal subsystem and i2c
> > subsystem.
> >
> > Temperature data reported using thermal subsystem will be used for
> > various cooling agents such as DVFS, fan control and shutdown the
> > system in case of critical temperature.
> >
> > Temperature data reported using i2c subsytem will be used by platform
> > manageability software running in remote host.
> >
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: devicetree@vger.kernel.org
> > Acked-by: mark gross <mgross@linux.intel.com>
> > Signed-off-by: C Udhayakumar <udhayakumar.c@intel.com>
> > Signed-off-by: Mark Gross <mgross@linux.intel.com>
> > ---
> >  .../bindings/misc/intel,intel-tsens.yaml      | 118 ++++++++++++++++++
> >  1 file changed, 118 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/misc/intel,intel-tsens.yaml
> >
>=20
> My bot found errors running 'make dt_binding_check' on your patch:
>=20
> yamllint warnings/errors:
>=20
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-
> review/Documentation/devicetree/bindings/misc/intel,intel-
> tsens.example.dt.yaml: example-0: tsens@20260000:reg:0: [0, 539361280, 0,
> 256] is too long
> 	From schema: /usr/local/lib/python3.8/dist-
> packages/dtschema/schemas/reg.yaml
>=20
> See https://patchwork.ozlabs.org/patch/1433609
>=20
This lint warning is due to missing address-cells and size-cells fields.

make dt_binding_check dtbs_check DT_SCHEMA_FILES=3DDocumentation/devicetree=
/bindings/misc/intel,intel-tsens.yaml=20
  CHKDT   Documentation/devicetree/bindings/misc/intel,intel-tsens.yaml
  DTC     Documentation/devicetree/bindings/misc/intel,intel-tsens.example.=
dt.yaml
  CHECK   Documentation/devicetree/bindings/misc/intel,intel-tsens.example.=
dt.yaml

Will update the fix in next patch version.
---
Thanks,
Udhay

> This check can fail if there are any dependencies. The base for a patch s=
eries
> is generally the most recent rc1.
>=20
> If you already ran 'make dt_binding_check' and didn't see the above error=
(s),
> then make sure 'yamllint' is installed and dt-schema is up to
> date:
>=20
> pip3 install dtschema --upgrade
>=20
> Please check and re-submit.