Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp173843pxb; Tue, 2 Feb 2021 02:12:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJwxaUdPrCGccfcWXw4v+mOzBw4t4eL4K9WPe80ySBo88CKTZUSgHuO7UANLgXRxxqJAXigE X-Received: by 2002:aa7:cfc3:: with SMTP id r3mr22967021edy.125.1612260736138; Tue, 02 Feb 2021 02:12:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612260736; cv=none; d=google.com; s=arc-20160816; b=PmpVyEAZlwfuJ8/bBKhsTDG2tKUm3AzzDqRSZDjorFlMhVmOX+9k+deBt3KL1waQsR xZ00FzbP2I296JutlAsYnpqWsd2go1vNcJ2zG3eCsehKrtTHf+TWcxMrikDKmgIsyANl cEVrxBDEETI+mDgFOWwDM6yAQzSUzj5RHx+onqUpqG9n7N5cFmgQ7HTwz41FXKNcv2BH UjEdOwRMZHnaxhab91+DA+tMwmA7uKp50bO4zhfXcT/VKlZr9xBOoq+Vwk58PfuqAVfv 7a6jDWn4Iat/UUWIHnaw6bw3LtDjMVXUcOSlBXWM6C73y7KxZvI9Ybq98XUcCpaGa71t g1mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=FYeJLFgukpjjaiX0ohZ3jkdwwwc8rHopLauzuSIyIdw=; b=RoLIZHgo+RYGWIlJbRLttuxBbQUe4Er0A/Oyvmlzo3iKEP1AFn6tjCKwXpmWgDDD1l CmazFbHFrxxBpLScEA7Wxhru6vsBfo2IJa9eE0ewEW2p+fZn9W90ofimQcw7aKqZndoA U8Lb6Uy7GoHJlMcfVvXPElo7FpHLRIK9dG4BMf+eEkO7ElXQEe63aEcsxPG6lwCx//B2 7Aaks6DaChSckw0ALlMk+ABCvnx4Apw4lpD7/f6fEOuLybursjzJVg5EKuAxbuoSQJUg r19nGmMMuXOdIaMEUvQDXl4QfTn2rhL0LwRRRYKiP1g20A6zo3mQUe+VezlpeoaXAQ1H 32iw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tV+v78pp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y25si12194111ejb.546.2021.02.02.02.11.49; Tue, 02 Feb 2021 02:12:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=tV+v78pp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230057AbhBBKKT (ORCPT + 99 others); Tue, 2 Feb 2021 05:10:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56426 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229883AbhBBKKF (ORCPT ); Tue, 2 Feb 2021 05:10:05 -0500 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA393C0613D6; Tue, 2 Feb 2021 02:09:25 -0800 (PST) Received: by mail-pl1-x62b.google.com with SMTP id b8so12181506plh.12; Tue, 02 Feb 2021 02:09:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=FYeJLFgukpjjaiX0ohZ3jkdwwwc8rHopLauzuSIyIdw=; b=tV+v78ppPBh5j1qozvGytXqYRH3YTJdedkA+I8BKPM/+ZtmYvrTzBWbeVfXbArKUSM iN4DyO4rLEKMayZ/QM19bmkFz6e2qX/7WaBp+PIDYEig7nWtknkexxzua6XvFhgpHqne lMEJZfTOQk7alc33ttk1hifGy5+zTtIrFKaHTSf6mg9Tfz5AO0tqYi4erZkvNM02mM7F 34qhUEHyyimt6uvazTjZyHv98SSh3Jyu5L4GyjX35aHc1AQuPb7R2MgE/5cvZaUS1c2/ oW/pTvabA1T2TAr4fqG1xQ9yyF5eenOs5p6igNbRJQAuRb/uXxQJoOvzreh2AVCzW5ld 4Zkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=FYeJLFgukpjjaiX0ohZ3jkdwwwc8rHopLauzuSIyIdw=; b=bOIzmPHvRpzgmS1MmP9MuyPEs2lHHMSPd5xHbplR/n2Nkuoow4i8P7LrCQQXSCeBS1 QvNEFeKzRbFhC6uC12aL5DJtv1XUUVGpZ3pvo/aD+YB1GW3KheCp70vakvw2UOeHTMI8 m8zvpgXyhpfjg2go7ZtNRWUnja84KPvwMWfX/ntL59ar6A4MAFRRmifjg1194UOWYQmZ TO48u5iO/2tHoiwEbDQXds+4SPq4RhWUov2Rj9DXUTOGwebtl3a2Xj91Do65PGYJXQRA LoThXRCR0PF8rrB4Aqhe2LXlpB/duLiDGceGSBlArcWt9GyXEKNwjokHvvnIeobRMGPY mYaA== X-Gm-Message-State: AOAM530B6XEA5phDOS5fsxDvc4l8ytxSDmE/WxwxWGcs/xP4Q7NFpd1R RdRQ8vWY/zKTKkDk7GCE5dqcHAMlQE5jlw== X-Received: by 2002:a17:90a:d02:: with SMTP id t2mr3397288pja.130.1612260565335; Tue, 02 Feb 2021 02:09:25 -0800 (PST) Received: from localhost ([2409:10:2e40:5100:6e29:95ff:fe2d:8f34]) by smtp.gmail.com with ESMTPSA id l2sm21403893pga.65.2021.02.02.02.09.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Feb 2021 02:09:24 -0800 (PST) Date: Tue, 2 Feb 2021 19:09:21 +0900 From: Sergey Senozhatsky To: Masahiro Yamada Cc: linux-kernel@vger.kernel.org, Petr Mladek , Sergey Senozhatsky , Steven Rostedt , John Ogness , Andy Shevchenko , Ard Biesheuvel , Borislav Petkov , Darren Hart , Dimitri Sivanich , Greg Kroah-Hartman , "H. Peter Anvin" , Ingo Molnar , Jiri Slaby , Mike Travis , Peter Jones , Russ Anderson , Steve Wahl , Thomas Gleixner , dri-devel@lists.freedesktop.org, linux-efi@vger.kernel.org, linux-fbdev@vger.kernel.org, platform-driver-x86@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 1/3] printk: use CONFIG_CONSOLE_LOGLEVEL_* directly Message-ID: References: <20210202070218.856847-1-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210202070218.856847-1-masahiroy@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (21/02/02 16:02), Masahiro Yamada wrote: > > CONSOLE_LOGLEVEL_DEFAULT is nothing more than a shorthand of > CONFIG_CONSOLE_LOGLEVEL_DEFAULT. > > When you change CONFIG_CONSOLE_LOGLEVEL_DEFAULT from Kconfig, almost > all objects are rebuilt because CONFIG_CONSOLE_LOGLEVEL_DEFAULT is > used in , which is included from most of source files. > > In fact, there are only 4 users of CONSOLE_LOGLEVEL_DEFAULT: > > arch/x86/platform/uv/uv_nmi.c > drivers/firmware/efi/libstub/efi-stub-helper.c > drivers/tty/sysrq.c > kernel/printk/printk.c > > So, when you change CONFIG_CONSOLE_LOGLEVEL_DEFAULT and rebuild the > kernel, it is enough to recompile those 4 files. Do you change CONFIG_CONSOLE_LOGLEVEL_DEFAULT so often that it becomes a problem? -ss