Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Feb 2021 11:30:56 +0100 (CET)
From:   Jiri Kosina <jikos@kernel.org>
To:     Nicolas Boichat <drinkcat@chromium.org>
cc:     Benjamin Tissoires <benjamin.tissoires@redhat.com>,
        Dmitry Torokhov <dtor@chromium.org>,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] HID: google: Get HID report on probe to confirm tablet
 switch state
In-Reply-To: <20210115134212.v2.1.I41b9795e4b5bda7209eb9099aebdc6a29677391e@changeid>
Message-ID: <nycvar.YFH.7.76.2102021130440.28696@cbobk.fhfr.pm>
References: <20210115134212.v2.1.I41b9795e4b5bda7209eb9099aebdc6a29677391e@changeid>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Fri, 15 Jan 2021, Nicolas Boichat wrote:

> This forces reading the base folded state anytime the device is
> probed, to make sure it's in sync.
> 
> This is useful after a reboot, if the device re-enumerates for
> any reason (e.g. ESD shock), or if the driver is unbound/rebound
> (debugging/testing).
> 
> Without this, the tablet switch state is only synchronized after a
> key is pressed (since the device would then send a report that
> includes the switch state), leading to strange UX (e.g. UI
> mode changes when a key is pressed after reboot).
> 
> This is not a problem on detachable base attach, as the device,
> by itself, sends a report after it is booted up.
> 
> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>

Applied, thanks Nicolas.

-- 
Jiri Kosina
SUSE Labs