Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp212669pxb;
        Tue, 2 Feb 2021 03:20:54 -0800 (PST)
X-Google-Smtp-Source: ABdhPJwEyeLIcj/h3mvU7Aw7N32mbOCPJXLMVUVKKJM1fgJNlXUB53m+saYrGYBkgq7KFCZu6qq1
X-Received: by 2002:a17:906:a448:: with SMTP id cb8mr6233068ejb.174.1612264854074;
        Tue, 02 Feb 2021 03:20:54 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1612264854; cv=none;
        d=google.com; s=arc-20160816;
        b=AH4ZMfrzDDXscawLCa6MOJY9k8ypUAj/DTY2fC3xBlRAYG1Ot1M+gCQBE/6A8vzW8Z
         lPplXmdZz4W9cz7WdIUxI7CJgtXFSmwCB+ZN7vpGxfXITn9dXpl88dhNUHLkym+wpKh0
         RH842iZfdeVsH/zcauR5ISF/wvqKmLcoOkAhlPLPoGQT9CVFO6HJqdP7Ak62TW3iK/g4
         uqyEpIu2DertgrjPhRBOy4mR4Uicn2Qyyul7QU/iGVBCFwof4ZnCofOJPBdAVULvkI6X
         iUdaMDj+0YYDNTVX2Wq5oOfZEpivfVrgIMkVQ8Vxa8P8m++rE84bmb5S8tAPoX+nssnQ
         vFsw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=CQ9zGVYMkZDgqnZqGbrB9lzE5Exqb3egEOOqmcGkc8I=;
        b=ToIuoqjfrj9MynudI78bKErCpb6HRPSsWK/rzNJHQ+xvVgvANY9kAZZ6cjKXTUPtMK
         JAOus1l155YjilLCGhf1gNoGfV3fn+x5/PNrKSdB7vhqgJ5z/C2EczoXeXOfpQDoNJOL
         v4epe7G7rdeJ9FjCKOO8NpAxO9z9P/o9FTkPEb1n98yfdr2SFiWwO0to6pWOjycS4xKt
         gzYA5hQ55f7cncxsgLxRt/tkRUwhBT5ryWw83R9molWwaAfMCg2SfLwmbWlSOghRRjWP
         Brn1mOUYEyr747vSH2FJr9eJihZWVoDauPSzMBfTNdRLBaCkQXmLLZWQgWr4r7re7Tpf
         CWnA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ceUgFz1X;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id d4si11771766edu.106.2021.02.02.03.20.29;
        Tue, 02 Feb 2021 03:20:54 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ceUgFz1X;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229581AbhBBLTk (ORCPT <rfc822;lkml.akiyano@gmail.com>
        + 99 others); Tue, 2 Feb 2021 06:19:40 -0500
Received: from mail.kernel.org ([198.145.29.99]:56962 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229466AbhBBLTj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 2 Feb 2021 06:19:39 -0500
Received: by mail.kernel.org (Postfix) with ESMTPSA id 15E7964E31;
        Tue,  2 Feb 2021 11:18:58 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
        s=korg; t=1612264738;
        bh=YrUx7bGau1958a2cy3yc4xrRn2W1VaeQs0FQoQPA12w=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=ceUgFz1Xa0BCimbRZX0lM73HzKnYFjS2uZ2kNNifB7ZxnM27lD52ieTOKFRoNr52m
         u5JZ58Q8i9lRJysZLIH6JHtZ6bzCSK8yHKjn5AMyG+Q/rmZlSpVO1ichbcnhVoBJJJ
         nyDxD9gb2C68EIh2WLZeoQhjejzGT+Cq5hNygn/A=
Date:   Tue, 2 Feb 2021 12:18:53 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Avri Altman <avri.altman@wdc.com>
Cc:     "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bart Van Assche <bvanassche@acm.org>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Daejun Park <daejun7.park@samsung.com>,
        alim.akhtar@samsung.com, asutoshd@codeaurora.org,
        Zang Leigang <zangleigang@hisilicon.com>,
        Avi Shchislowski <avi.shchislowski@wdc.com>,
        Bean Huo <beanhuo@micron.com>, cang@codeaurora.org,
        stanley.chu@mediatek.com
Subject: Re: [PATCH v2 9/9] scsi: ufshpb: Make host mode parameters
 configurable
Message-ID: <YBk1HZijbtkMrO0O@kroah.com>
References: <20210202083007.104050-1-avri.altman@wdc.com>
 <20210202083007.104050-10-avri.altman@wdc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210202083007.104050-10-avri.altman@wdc.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 02, 2021 at 10:30:07AM +0200, Avri Altman wrote:
> +struct attribute_group ufs_sysfs_hpb_param_group = {
> +	.name = "hpb_param_sysfs",

Shouldn't this be "hpb_param"?  Why the trailing "_sysfs", doesn't that
look odd in the directory path?

thanks,

greg k-h