Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp220153pxb; Tue, 2 Feb 2021 03:34:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJxfL9IiYvynyWqYcOCbEn48bMlgBONsxCVjeIxLqtVghKHkKtp/bemACki34IQur/susJvU X-Received: by 2002:a05:6402:3186:: with SMTP id di6mr23386792edb.45.1612265645492; Tue, 02 Feb 2021 03:34:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612265645; cv=none; d=google.com; s=arc-20160816; b=JaXyfT+cljdrP+gdCE9dgtH9Qgt1RjHHtgl0LTk8RjRaUSMHK/h+dhn8MDPrA/zpmW rUtJWuE466QLmM9B9MEPCFv4iOYWBmIFxWLUmUfn+MoJVAGdGOk+HSDzmripGENReArB e9wOs6dS64yItWqx8lSSOyrouMBmvLxtBOavm2oUQiVy4F2Uy1hXsSfevImeEY2SukmL uCeEDOaRTDfN0Gvv+S6UFC52XSfwZ89gMQc+bsNdrye5D3lmyQIcd9g6AI9mMSdby2ZN yj3NojKikg+//RWgf2X0ILFkAEGGwHWjB8YwpfSDgvYqGzSDCnxSiH2I3+dsn+OSJpy4 Eh9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=vb03IXhfCSNtRMRTi8pDkO4PO1qBxUHpcd49KNh86Zk=; b=yYtJpUw5w/x0SkN56JrDv/307uZ9DAQNypJYigAiyEwJV/LSUAfeVLmHeUwemHk5Eq 7qEIbxFhJ1TFyHYnoUhc/KXv3Gdo/0B6yzxAQAbCzMabnhdvhUtnt2wo8cHg1Mek9YEK 96Scj+DqurENiXTj75gSor/TYJESL8EvxQyjoVnqHDSZZyWgIkvcluBxhezi4VPDZKL6 Sn/9+QXm6Mi3+5vtjPqEfeXyFg5yxBhUqqqWwqSgjtdGFCHV+Oa0OWsqLIv/8QBjUqvr G1bb9TV1vxNglfWMXOBL+BcH9cRURfJMqvc3Qjt5La0/vxVPWc7WhJOZsYAEhSWIXxGj gWoA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ga25si11488241ejc.296.2021.02.02.03.33.41; Tue, 02 Feb 2021 03:34:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231132AbhBBLai (ORCPT + 99 others); Tue, 2 Feb 2021 06:30:38 -0500 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:38039 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230518AbhBBL0x (ORCPT ); Tue, 2 Feb 2021 06:26:53 -0500 X-Originating-IP: 86.202.109.140 Received: from localhost (lfbn-lyo-1-13-140.w86-202.abo.wanadoo.fr [86.202.109.140]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id B7FD82000C; Tue, 2 Feb 2021 11:26:01 +0000 (UTC) From: Alexandre Belloni To: linux-rtc@vger.kernel.org, Alessandro Zummo , Alexandre Belloni Cc: linux-kernel@vger.kernel.org Subject: [PATCH 2/2] rtc: rv3028: remove useless warning messages Date: Tue, 2 Feb 2021 12:25:55 +0100 Message-Id: <20210202112555.3611729-2-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210202112555.3611729-1-alexandre.belloni@bootlin.com> References: <20210202112555.3611729-1-alexandre.belloni@bootlin.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Remove voltage low messages as userspace has a proper way to get the information and react on it. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rv3028.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-rv3028.c b/drivers/rtc/rtc-rv3028.c index 6d07f8261c69..0c48d980d06a 100644 --- a/drivers/rtc/rtc-rv3028.c +++ b/drivers/rtc/rtc-rv3028.c @@ -265,9 +265,6 @@ static irqreturn_t rv3028_handle_irq(int irq, void *dev_id) return IRQ_NONE; } - if (status & RV3028_STATUS_PORF) - dev_warn(&rv3028->rtc->dev, "Voltage low, data loss detected.\n"); - status &= ~RV3028_STATUS_PORF; if (status & RV3028_STATUS_TF) { @@ -313,10 +310,8 @@ static int rv3028_get_time(struct device *dev, struct rtc_time *tm) if (ret < 0) return ret; - if (status & RV3028_STATUS_PORF) { - dev_warn(dev, "Voltage low, data is invalid.\n"); + if (status & RV3028_STATUS_PORF) return -EINVAL; - } ret = regmap_bulk_read(rv3028->regmap, RV3028_SEC, date, sizeof(date)); if (ret) @@ -828,9 +823,6 @@ static int rv3028_probe(struct i2c_client *client) if (ret < 0) return ret; - if (status & RV3028_STATUS_PORF) - dev_warn(&client->dev, "Voltage low, data loss detected.\n"); - if (status & RV3028_STATUS_AF) dev_warn(&client->dev, "An alarm may have been missed.\n"); -- 2.29.2