Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp231711pxb; Tue, 2 Feb 2021 03:54:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJxR7t98oDyMDD1yIb3jX+Z6OeXFCgWZ+A55BYfADkqyjkj0Lm3r2M9aOa5uI/1/IkzLy3BF X-Received: by 2002:a17:906:28d6:: with SMTP id p22mr22363695ejd.365.1612266861441; Tue, 02 Feb 2021 03:54:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612266861; cv=none; d=google.com; s=arc-20160816; b=CI7W732+2Zq4JLlbWrWTz7zTZeaOYIz6sJ+i64iUSAa2i9k8tR7/5OMZivAskoOoaA IOJLOJnOi3SEPzZCdEbxHEcGAKcKEr99t0DZqo4qRKIgcHgJ9K4j5b33SGnhWJBY5jRx wkYuzJAnBW8eWtF/LdqLW63vQmynds3iAHChp69y9kvvYZ5OlpPQtOfa/m8v+26c7Osw 4wkA4cL21pNiAIx7+1nzCOZqgglTfk/FEtXQbZYmQF/9h6RnaDjmkZPL+k/kTvcNiYre yom1IXhjtUV/s1x+N/fMnC//EXeQne05ZQdfIjzc7P6Zt8ZfpDT3bW1nuQfwZVLRwDVP MYaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=559QZEZz5BCfG2sXOj+YhieJ2MHUijrtYeXNQXZyxXc=; b=WYp5OzoQ+C1wV7KvhcF6O3GhMuuVExaPXYMXp230K5R2bbgmAlrF6c5hSvcUcu6DD+ a3Y/U7/gKSuMj/1UGIWKTPwL2btS0VYJJxCUZVKaFR5pNYy1o+3X4UmudLvgf8iDjm/K khfVZrzjxWvj3CKiujPt4grDYc5mbgKy6dmfo76Umdm7mPKQPQNBJLLjSBEqX0h9PvHC 3IqQq5jlrCShrj56crJWKFJNa081K/1Iddjm2PIizBqUBVgzU2PPojqhAgiW0GhJG8tv yk4eq7TsOB/VEmwd9EscfJpaJz13uAAWc0PLiTIXnBmXIW9Ib8OLkbbjV5vHeIZAo11u a9DQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KK9bYO37; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p5si2496429edq.266.2021.02.02.03.53.56; Tue, 02 Feb 2021 03:54:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KK9bYO37; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231375AbhBBLwR (ORCPT + 99 others); Tue, 2 Feb 2021 06:52:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:40944 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231349AbhBBLwM (ORCPT ); Tue, 2 Feb 2021 06:52:12 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id AC8F764EDA; Tue, 2 Feb 2021 11:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1612266691; bh=oQSn79aftyH7uGpea6Y6ZKbRHlClxKT7EnCy9j5mu6I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KK9bYO37E2FaElLdXySz5TIENWBjx4vahDzo3fjQ2KiVwfrHBdCX2vnld8JVRISxV Gxm8/IYe1ZWln0kVNauPkUQ72wOUo9fsFw1FmPNJibRbz5GZbYeN23ARQ1Mt4UP5hy kdMOi+jX0oYFbiVyI1B6stNgkDOhExSocbSHX02Q= Date: Tue, 2 Feb 2021 12:51:26 +0100 From: Greg KH To: Avri Altman Cc: "James E . J . Bottomley" , "Martin K . Petersen" , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Bart Van Assche , yongmyung lee , Daejun Park , "alim.akhtar@samsung.com" , "asutoshd@codeaurora.org" , Zang Leigang , Avi Shchislowski , Bean Huo , "cang@codeaurora.org" , "stanley.chu@mediatek.com" Subject: Re: [PATCH v2 3/9] scsi: ufshpb: Add region's reads counter Message-ID: References: <20210202083007.104050-1-avri.altman@wdc.com> <20210202083007.104050-4-avri.altman@wdc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 02, 2021 at 11:23:17AM +0000, Avri Altman wrote: > > > > > > On Tue, Feb 02, 2021 at 10:30:01AM +0200, Avri Altman wrote: > > > @@ -175,6 +179,8 @@ struct ufshpb_lu { > > > > > > /* for selecting victim */ > > > struct victim_select_info lru_info; > > > + struct work_struct ufshpb_normalization_work; > > > + unsigned long work_data_bits; > > > > You only have 1 "bit" being used here, so perhaps just a u8? Please > > don't use things like "unsigned long" for types, this isn't Windows :) > I am using it for atomic bit operations. Ah, and that requires "unsigned long"? Ok, nevermind :)