Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 425Yz0lugLTIQw4XD/XKWlaiBaXuqlOYysrX8Mpnm6lohteb6EC8vxHfftMIbLjjvUrYdkWucg
 lkiUCRlcG4ifiSoqFNa/WBbA9cOI74Ig9Tj/HiO79warUVjkTENWHuSMBqxxciF2iotX6XZtAZ
 4cW2LIoXLwmEIqMqj1dWS9iGt6Zz4+iQj7mQTC+Ukx+wZPN4qd9ClXgEDkidwapFji23OpOMAi
 YttpXz1vCoJpR1uTxh9CpK/nIjpKxPlxtqMatKahOKoXvP5650Gz9LmjBIms1l8ISNMlygT0yO
 duw=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K . Petersen" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Bart Van Assche <bvanassche@acm.org>,
        yongmyung lee <ymhungry.lee@samsung.com>,
        Daejun Park <daejun7.park@samsung.com>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        Zang Leigang <zangleigang@hisilicon.com>,
        Avi Shchislowski <Avi.Shchislowski@wdc.com>,
        Bean Huo <beanhuo@micron.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>
Subject: RE: [PATCH v2 2/9] scsi: ufshpb: Add host control mode support to
 rsp_upiu
Thread-Topic: [PATCH v2 2/9] scsi: ufshpb: Add host control mode support to
 rsp_upiu
Thread-Index: AQHW+T20gCB3H9uAPUqvS/piDh3jCapEtnsAgAACqhCAAAf6gIAAAHXg
Date:   Tue, 2 Feb 2021 11:54:33 +0000
Message-ID: <DM6PR04MB6575D836D307AA89D77E8640FCB59@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20210202083007.104050-1-avri.altman@wdc.com>
 <20210202083007.104050-3-avri.altman@wdc.com> <YBkz7m7uMP4iJ/qn@kroah.com>
 <DM6PR04MB65754BB7B07301D2B35B6490FCB59@DM6PR04MB6575.namprd04.prod.outlook.com>
 <YBk827Gh9JU3sNJZ@kroah.com>
In-Reply-To: <YBk827Gh9JU3sNJZ@kroah.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 02b4cccf-0752-4ee1-c815-08d8c7714e7f
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2021 11:54:33.3780
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: c2CEJUNHWeI+T3YHfRbz+K8yhuyNNl5/WKzuBraj/QypYZ7HCyOip/FMvSXcvN8gr5emwJDx8L1Gu0jnRSD7zw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB6139
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> On Tue, Feb 02, 2021 at 11:24:04AM +0000, Avri Altman wrote:
> >
> > >
> > > On Tue, Feb 02, 2021 at 10:30:00AM +0200, Avri Altman wrote:
> > > > diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h
> > > > index afeb6365daf8..5ec4023db74d 100644
> > > > --- a/drivers/scsi/ufs/ufshpb.h
> > > > +++ b/drivers/scsi/ufs/ufshpb.h
> > > > @@ -48,6 +48,11 @@ enum UFSHPB_MODE {
> > > >       HPB_DEVICE_CONTROL,
> > > >  };
> > > >
> > > > +enum HPB_RGN_FLAGS {
> > > > +     RGN_FLAG_UPDATE =3D 0,
> > > > +     RGN_FLAG_DIRTY,
> > > > +};
> > > > +
> > > >  enum UFSHPB_STATE {
> > > >       HPB_PRESENT =3D 1,
> > > >       HPB_SUSPEND,
> > > > @@ -109,6 +114,7 @@ struct ufshpb_region {
> > > >
> > > >       /* below information is used by lru */
> > > >       struct list_head list_lru_rgn;
> > > > +     unsigned long rgn_flags;
> > >
> > > Why an unsigned long for a simple enumerated type?  And why not make
> > > this "type safe" by explicitly saying this is an enumerated type
> > > variable?
> > I am using it for atomic bit operations.
>=20
> That's not obvious given you have an enumerated type above.  Seems like
> an odd mix...
Done.
Will make it clear that those are bit indices.