Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Ioana Ciornei <ioana.ciornei@nxp.com>
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
CC:     Ioana Ciocoi Radulescu <ruxandra.radulescu@nxp.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "linux@armlinux.org.uk" <linux@armlinux.org.uk>,
        "ast@kernel.org" <ast@kernel.org>,
        "daniel@iogearbox.net" <daniel@iogearbox.net>,
        "hawk@kernel.org" <hawk@kernel.org>,
        "john.fastabend@gmail.com" <john.fastabend@gmail.com>,
        "andrii@kernel.org" <andrii@kernel.org>,
        "kafai@fb.com" <kafai@fb.com>,
        "songliubraving@fb.com" <songliubraving@fb.com>,
        "yhs@fb.com" <yhs@fb.com>,
        "kpsingh@kernel.org" <kpsingh@kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "bpf@vger.kernel.org" <bpf@vger.kernel.org>
Subject: Re: [PATCH] dpaa2-eth: Simplify the calculation of variables
Thread-Topic: [PATCH] dpaa2-eth: Simplify the calculation of variables
Thread-Index: AQHW+UqUQ+Vok9fAFUqJqoxZiaDPhqpEzMMA
Date:   Tue, 2 Feb 2021 12:33:56 +0000
Message-ID: <20210202123356.ythsfeyfk2uuegcc@skbuf>
References: <1612260157-128026-1-git-send-email-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <1612260157-128026-1-git-send-email-jiapeng.chong@linux.alibaba.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <28058608A25B884482ECA752160330CC@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 38753a5a-bc39-4860-687b-08d8c776cf6e
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Feb 2021 12:33:57.1553
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: AtNWTsV/AZ8j4kInmUjfyqmC3P/tG+LbLpYmyiIOQFokv9fXkbdU9EVTISsPyfVc8rZ96Q19yLjo1KZx92NiVA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR04MB6445
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 02, 2021 at 06:02:37PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>=20
> ./drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c:1651:36-38: WARNING
> !A || A && B is equivalent to !A || B.
>=20
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Ioana Ciornei <ioana.ciornei@nxp.com>

> ---
>  drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c b/drivers/n=
et/ethernet/freescale/dpaa2/dpaa2-eth.c
> index fb0bcd1..93f84c9 100644
> --- a/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
> @@ -1648,7 +1648,7 @@ void dpaa2_eth_set_rx_taildrop(struct dpaa2_eth_pri=
v *priv,
>  	 * CG taildrop threshold, so it won't interfere with it; we also
>  	 * want frames in non-PFC enabled traffic classes to be kept in check)
>  	 */
> -	td.enable =3D !tx_pause || (tx_pause && pfc);
> +	td.enable =3D !tx_pause || pfc;
>  	if (priv->rx_cgtd_enabled =3D=3D td.enable)
>  		return;
> =20
> --=20
> 1.8.3.1
> =