Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp620492pxb; Tue, 2 Feb 2021 13:26:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJxogQ3jifp4ImAdoWfsbhNHpA1hEbwRg1JYunj0cyxalcfXSpXzJzEZy0iiA+J/JIosX2uE X-Received: by 2002:a17:906:2747:: with SMTP id a7mr25054435ejd.250.1612301194037; Tue, 02 Feb 2021 13:26:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612301194; cv=none; d=google.com; s=arc-20160816; b=h0AKACeC4bx6MIMqDWAm8ARbpJVeAyWZ7shIDIYF0rPxErzq2eXZycHtnnPCXsC+64 0QTLZnkwcFuTtJxyY+l4B2jMEQg1z8RXU7wE2pVpaX5KV5xW0aKVg2tPzmFBKDw2QVT4 AiNDpCB9yUaczsSWr298cf4mC3qQhAeKad++cIAuoII7u4JnbG5+arpDkW4z26eiU+01 Dgd1odlXyxobjP7fc6vWzZz59SOAGXklCYv2WqfdBouImFc/YTW1lWvsRNbh8N5zuUku rsCkuG35kxz2wCCkwUeXfj8fRDrIjw1oZ85mxhLXg6LgDe9JAVnUGykn1dxHqjD57zsH BgVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:references:in-reply-to :message-id:date:subject:to:from:dkim-signature; bh=pCyObRoYs4TuqGUabO/rMbP3htemyH/3g4S6VzT5G0o=; b=G9Y2I4bcUF3AOgqxu8a7xYQ+2a/kRRNyYflsbMeJHgrYIBhx3EaGIKVLWeVRC0Y8m3 oos8Qk9TVzgOjJnzq9TPtMhIv4+gVgrz+R9Zq9M3z2zKfCOEX6nrqXcjKhpf2ABgmT9Y k17It3l0gZk6G7pZFu8dB4sdj56LNAQeneSoXtxIBrRw2EZ8G8LkJUu5nafeRQ7oOdce zRZ70T6lBqceFCNz1nybEfJ7AIQ/V8iy0QJXM1VTOOiRWLGQn0tgf5SeT7RKHNv4ag6H xgwGyg0LaxTCZmn8rdaeAgkMdjXieN6N2HQosJFTU4VFdHk1e4do5XMyqH81BxSzWYzo fdsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=IwwkVyyM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dv16si39489ejb.226.2021.02.02.13.26.07; Tue, 02 Feb 2021 13:26:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=IwwkVyyM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232008AbhBBMo2 (ORCPT + 99 others); Tue, 2 Feb 2021 07:44:28 -0500 Received: from smtprelay-out1.synopsys.com ([149.117.87.133]:56160 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231748AbhBBMmD (ORCPT ); Tue, 2 Feb 2021 07:42:03 -0500 Received: from mailhost.synopsys.com (mdc-mailhost1.synopsys.com [10.225.0.209]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 3F5EFC00C6; Tue, 2 Feb 2021 12:41:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1612269662; bh=RPtJq9pnB6c2RL81eMcBv6mkc0ffZocP1N1iwYCqspQ=; h=From:To:Subject:Date:In-Reply-To:References:In-Reply-To: References:From; b=IwwkVyyMQapxBBoJWq4RUzHd09/VboaJubAcNZPn7g1k6jZVeByBQfmtARAxhjUpL vaZ5BJ+LPVmN/aWQ4CptBZMZ+f/jU9SEw5WAgqYLsukZByGBjs5zGC3hA43ydC5gIt bg2LoNKtQWjV/DZA5DSDHCa81FINubG1+ZpOKVIpPamucxtPx/KHhXhEzzdUXaSGex zdmhNPQFeRlM82f8phxAzjulc3bTyfE4DsVhXK9a/mxEtFcBtB+aLuHn40lLJGfNQp +SM7/t2/qYueh34UBh/3V+7VlaEnLr7rOXFcstJtE4fYRqaGeBkbNeu5XVAKcy2o6L jg8QFCLCQLuxw== Received: from de02dwia024.internal.synopsys.com (de02dwia024.internal.synopsys.com [10.225.19.81]) by mailhost.synopsys.com (Postfix) with ESMTP id 0527AA0249; Tue, 2 Feb 2021 12:41:01 +0000 (UTC) X-SNPS-Relay: synopsys.com From: Gustavo Pimentel To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Gustavo Pimentel , Vinod Koul , Dan Williams Subject: [PATCH v2 15/15] dmaengine: dw-edma: Add pcim_iomap_table return checker Date: Tue, 2 Feb 2021 13:40:29 +0100 Message-Id: <0516469618b38b74f997c36bfc9ca3bad9836832.1612269537.git.gustavo.pimentel@synopsys.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Detected by CoverityScan CID 16555 ("Dereference null return") Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-pcie.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/drivers/dma/dw-edma/dw-edma-pcie.c b/drivers/dma/dw-edma/dw-edma-pcie.c index 686b4ff..7445033 100644 --- a/drivers/dma/dw-edma/dw-edma-pcie.c +++ b/drivers/dma/dw-edma/dw-edma-pcie.c @@ -238,6 +238,9 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, dw->rd_ch_cnt = vsec_data.rd_ch_cnt; dw->rg_region.vaddr = pcim_iomap_table(pdev)[vsec_data.rg.bar]; + if (!dw->rg_region.vaddr) + return -ENOMEM; + dw->rg_region.vaddr += vsec_data.rg.off; dw->rg_region.paddr = pdev->resource[vsec_data.rg.bar].start; dw->rg_region.paddr += vsec_data.rg.off; @@ -250,12 +253,18 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, struct dw_edma_block *dt_block = &vsec_data.dt_wr[i]; ll_region->vaddr = pcim_iomap_table(pdev)[ll_block->bar]; + if (!ll_region->vaddr) + return -ENOMEM; + ll_region->vaddr += ll_block->off; ll_region->paddr = pdev->resource[ll_block->bar].start; ll_region->paddr += ll_block->off; ll_region->sz = ll_block->sz; dt_region->vaddr = pcim_iomap_table(pdev)[dt_block->bar]; + if (!dt_region->vaddr) + return -ENOMEM; + dt_region->vaddr += dt_block->off; dt_region->paddr = pdev->resource[dt_block->bar].start; dt_region->paddr += dt_block->off; @@ -269,12 +278,18 @@ static int dw_edma_pcie_probe(struct pci_dev *pdev, struct dw_edma_block *dt_block = &vsec_data.dt_rd[i]; ll_region->vaddr = pcim_iomap_table(pdev)[ll_block->bar]; + if (!ll_region->vaddr) + return -ENOMEM; + ll_region->vaddr += ll_block->off; ll_region->paddr = pdev->resource[ll_block->bar].start; ll_region->paddr += ll_block->off; ll_region->sz = ll_block->sz; dt_region->vaddr = pcim_iomap_table(pdev)[dt_block->bar]; + if (!dt_region->vaddr) + return -ENOMEM; + dt_region->vaddr += dt_block->off; dt_region->paddr = pdev->resource[dt_block->bar].start; dt_region->paddr += dt_block->off; -- 2.7.4