Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp621051pxb; Tue, 2 Feb 2021 13:27:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJzAbfxWENW4LxvLZ0sBVgwsoOvIw17LW7G8usPtzaMoFqXjBpowMU/1BKro+WVKzPf5hEhv X-Received: by 2002:a50:a6ce:: with SMTP id f14mr58968edc.346.1612301258346; Tue, 02 Feb 2021 13:27:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612301258; cv=none; d=google.com; s=arc-20160816; b=inSJgR8PLnQdaxQoHqphXR/2gZWP3q33ClGL19oTVjb2RRn6mCtykX1mtTkkCiCSpl OdfSN7srVCbZWVwo9XZXdLFLWZgrYg3/EblISqYFeaotJbaGQr77iNDh0DFy+t9neyAV cXHKbioyPsDpGGJlsQ1KnzxL6E0jmpZjzaZPDf5APmcqLPHZLzo0IriuwQwagkCqMi9O cR2cIoEFmTMf+NaycmR5FLLXY6fUSsT9HI24bBxDFsvItYky/IUO+VGpSFufnbT3c8gL YY2eItEJJ8cBmAk3gM6utDP6D0tJk+I6RBDyzRRtd04lt5a86Y+fpHIbtWsmpo6zB+Ly NTkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:references:in-reply-to :message-id:date:subject:to:from:dkim-signature; bh=LeJkYXCorWtiaP+yCGj+HszRDmiDY/6LzTvN7R0PDJU=; b=DHGQ4t+ictcyyZmaAyVl+2AWEkusryP1w+66crU+XaDKMynt3StU1MHdLXd50LaUiA roUEoJ2ztGXaL9mk/S2Uk10p+CWSQaRUxEmtBTmkoicImLEm2hd+Z5aCYj4ybQJ0D/Me YauJPBaIFv9aOVckPBKqM7jzAguPgf5ca7DGUwViEDK8Y2rwY3MR/73NiVlY0q6uOTtR uqXMjBjXbkE4avfzHMva0zHjyW2TnVxP3MsyfMtgFV2KeG4Nk/vuVPgbs59xJjr/WY// P3ihyqrSG8hllfNSygINvRi9icUdtI9HCNRNP+70AgYGtfT1/oCkH9PScMvC+PGFx9nA 26Uw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b="L/XHqoQm"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p31si13682067edd.505.2021.02.02.13.27.11; Tue, 02 Feb 2021 13:27:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b="L/XHqoQm"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231533AbhBBMpY (ORCPT + 99 others); Tue, 2 Feb 2021 07:45:24 -0500 Received: from smtprelay-out1.synopsys.com ([149.117.87.133]:56148 "EHLO smtprelay-out1.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231783AbhBBMmD (ORCPT ); Tue, 2 Feb 2021 07:42:03 -0500 Received: from mailhost.synopsys.com (mdc-mailhost1.synopsys.com [10.225.0.209]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by smtprelay-out1.synopsys.com (Postfix) with ESMTPS id 81946C00C4; Tue, 2 Feb 2021 12:40:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1612269659; bh=71t8kLn/h4uRT+rZrsVOIM9WjcoyjC97XsyNd4xo0/8=; h=From:To:Subject:Date:In-Reply-To:References:In-Reply-To: References:From; b=L/XHqoQmi+tTG8itA3FEq1HB/YY4aCxTpEB3QQz1VPE1vh7nd8CF3fuQ5cHtZaV+/ U1TFm+svUq97t10CypnsII+or3fcN4bu0tpR7L8u0W89Yr87+d15pEKkmFAtE850za UuknwY9yCj1/vA08JRjY4NLCXBE8h/fj1cZbA1Tp12LwStlPElw4KG3G7WUnbqldPR 4xWd2TD9Q0gO462ivm8oUPYDA1kPtx3rfwuGlsEvUpm1NQITYfedKesPwDy8eFmq4H zN91cEsS9wHMHVW2yzEpraHCm2NZOzf1hYGapCWi6TXY8Z89cJYHUYu8vTCqQgU/q2 AGz+YAVWxxIkg== Received: from de02dwia024.internal.synopsys.com (de02dwia024.internal.synopsys.com [10.225.19.81]) by mailhost.synopsys.com (Postfix) with ESMTP id 52DBAA024C; Tue, 2 Feb 2021 12:40:58 +0000 (UTC) X-SNPS-Relay: synopsys.com From: Gustavo Pimentel To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, Gustavo Pimentel , Dan Williams , Vinod Koul Subject: [PATCH v2 12/15] dmaengine: dw-edma: Fix crash on loading/unloading driver Date: Tue, 2 Feb 2021 13:40:26 +0100 Message-Id: X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When the driver is compiled as a module and loaded if we try to unload it, the Kernel shows a crash log. This Kernel crash is due to the dma_async_device_unregister() call done after deleting the channels, this patch fixes this issue. Signed-off-by: Gustavo Pimentel --- drivers/dma/dw-edma/dw-edma-core.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/dma/dw-edma/dw-edma-core.c b/drivers/dma/dw-edma/dw-edma-core.c index 8d8292e..f7a1930 100644 --- a/drivers/dma/dw-edma/dw-edma-core.c +++ b/drivers/dma/dw-edma/dw-edma-core.c @@ -986,22 +986,21 @@ int dw_edma_remove(struct dw_edma_chip *chip) /* Power management */ pm_runtime_disable(dev); + /* Deregister eDMA device */ + dma_async_device_unregister(&dw->wr_edma); list_for_each_entry_safe(chan, _chan, &dw->wr_edma.channels, vc.chan.device_node) { - list_del(&chan->vc.chan.device_node); tasklet_kill(&chan->vc.task); + list_del(&chan->vc.chan.device_node); } + dma_async_device_unregister(&dw->rd_edma); list_for_each_entry_safe(chan, _chan, &dw->rd_edma.channels, vc.chan.device_node) { - list_del(&chan->vc.chan.device_node); tasklet_kill(&chan->vc.task); + list_del(&chan->vc.chan.device_node); } - /* Deregister eDMA device */ - dma_async_device_unregister(&dw->wr_edma); - dma_async_device_unregister(&dw->rd_edma); - /* Turn debugfs off */ dw_edma_v0_core_debugfs_off(chip); -- 2.7.4