Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp627800pxb; Tue, 2 Feb 2021 13:40:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJyz+tOwFnOPz3ZG3n/3gX8xcHQxITUwfh4PxjGXsYBc3QRuQL6Sl5k5538mM/9TdveSzIzT X-Received: by 2002:a17:907:3fa6:: with SMTP id hr38mr43646ejc.24.1612302000620; Tue, 02 Feb 2021 13:40:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612302000; cv=none; d=google.com; s=arc-20160816; b=jx+cTTGJvQyaNzFv16cwKEFNuiYHqY5bpHDgKB6HKdaPgx8WObWf4iDQOjSvgQeeRp S0fhdzrylCBlH1GFX6oBOgTU1H4TbM/LdMKihLRN7T217p3NvurHzJQFApIsNnId2r7E 5nd3CFjsz34OpxxqGyxT2oSbnoyDW3tRReOEb3Gg7jhn8kkVNfgTsULF+KHFkShdGxYD bpA0Fb56O7jTAXkVCGy7Ex8xpHie2zVE6R4LAscacsjRFCpimXAEQ9VeK9yKV3N3MK/1 NMIKt5iFRhKTyO8dfWcXwTvECvh4PskmxTtjvHXSh8nqSESKSjoK6fZ546kmJD6n1j9E Umhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:reply-to:cc:from:to :dkim-signature:date; bh=wkrsDsmJrKMWDTAP0CgzaSOfN+12VWFr81Nb1Qb7W0A=; b=xIoZCVZXde1GlU+n1j6ZmR2cvn6A/NNrORp4I/WZo1EU/3xidloiI+QPJfj0I4gFrN 473rfxc5q9K9v6pvOeJf9hEPWUJNKWVptvUulVC8K7gTJprRh3qvQYghuBNd70ONMZdv Fw+mUerraPktS5HigZc+5LBcC3BP02Tlz0niTN7g5pRQvgs7VcFHgkgv2vmbwV2TQMUR oHGbBmJESfvJEF7RnJw28Z8de79TRW9YsBxQ718tRkWeLZyD+fenh/SlK2kreVLs+T6y oT7lnzEi8M2xDffo5ClH05PL/BZtJxJxKQj7CM+3Ujvh0dIENyiQ4yciuik2XAszuuUt RL0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@pm.me header.s=protonmail header.b=K7qCB1jw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=pm.me Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n13si43821ejc.732.2021.02.02.13.39.22; Tue, 02 Feb 2021 13:40:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@pm.me header.s=protonmail header.b=K7qCB1jw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=pm.me Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231733AbhBBNTG (ORCPT + 99 others); Tue, 2 Feb 2021 08:19:06 -0500 Received: from mail-40136.protonmail.ch ([185.70.40.136]:62640 "EHLO mail-40136.protonmail.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230025AbhBBNOI (ORCPT ); Tue, 2 Feb 2021 08:14:08 -0500 Date: Tue, 02 Feb 2021 13:13:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pm.me; s=protonmail; t=1612271590; bh=wkrsDsmJrKMWDTAP0CgzaSOfN+12VWFr81Nb1Qb7W0A=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=K7qCB1jwBd70fF7fnDVz7zwMpJCi3aRlkq6AbbrG0dMIDUTBab250VWxXM7d/JBeC imiSnG9/VbWmDCmxV4UOshgzGyFI06qGkOkjCPKDhepiMo/1oMQeS9oWgXTMs+qyXq D2ICe8QN/OKumGGOm2iLXsg0gHJUVLLbKU7F0CCCuB34jgsQAHDShDBtHlNkHppNNn JIKcB4hwUJDpwYyFakZ7zUnxsauJA8AMVC2iJMU7lT/KMC1WvYnzMj00ZtU0KrPxwN jyS8F0rt7d/4XC1FKuoG9uDC1kT6Fi/OnhzOUUiUB32HwX6pgyjODc3AEFyO2DD82t GQ5im5p3D47HQ== To: Jakub Kicinski From: Alexander Lobakin Cc: Alexander Lobakin , "David S. Miller" , John Hubbard , David Rientjes , Yisen Zhuang , Salil Mehta , Jesse Brandeburg , Tony Nguyen , Saeed Mahameed , Leon Romanovsky , Andrew Morton , Jesper Dangaard Brouer , Ilias Apalodimas , Jonathan Lemon , Willem de Bruijn , Randy Dunlap , Pablo Neira Ayuso , Dexuan Cui , Jakub Sitnicki , Marco Elver , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org, linux-mm@kvack.org Reply-To: Alexander Lobakin Subject: Re: [PATCH v3 net-next 0/5] net: consolidate page_is_pfmemalloc() usage Message-ID: <20210202131233.4180-1-alobakin@pm.me> In-Reply-To: <20210201171835.690558df@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> References: <20210131120844.7529-1-alobakin@pm.me> <20210201171835.690558df@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-1.2 required=10.0 tests=ALL_TRUSTED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=disabled version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on mailout.protonmail.ch Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jakub Kicinski Date: Mon, 1 Feb 2021 17:18:35 -0800 > On Sun, 31 Jan 2021 12:11:16 +0000 Alexander Lobakin wrote: > > page_is_pfmemalloc() is used mostly by networking drivers to test > > if a page can be considered for reusing/recycling. > > It doesn't write anything to the struct page itself, so its sole > > argument can be constified, as well as the first argument of > > skb_propagate_pfmemalloc(). > > In Page Pool core code, it can be simply inlined instead. > > Most of the callers from NIC drivers were just doppelgangers of > > the same condition tests. Derive them into a new common function > > do deduplicate the code. >=20 > Please resend, this did not get into patchwork :/ I suspected it would be so as I got reports about undelivered mails due to unavailability of vger.kernel.org for some reasons Will do. Al