Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Feb 2021 17:19:57 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
Cc:     David Howells <dhowells@redhat.com>,
        Ilya Dryomov <idryomov@gmail.com>, ceph-devel@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ceph: Fix an Oops in error handling
Message-ID: <20210202141957.GC20820@kadam>
References: <YBjne8A1gn0mvQtT@mwanda>
 <f0477211cafbdc24883e978ab976610333f5fb67.camel@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f0477211cafbdc24883e978ab976610333f5fb67.camel@kernel.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Tue, Feb 02, 2021 at 07:37:57AM -0500, Jeff Layton wrote:
> On Tue, 2021-02-02 at 08:47 +0300, Dan Carpenter wrote:
> > The "req" pointer is an error pointer and not NULL so this check needs
> > to be fixed.
> > 
> > Fixes: 1cf7fdf52d5a ("ceph: convert readpage to fscache read helper")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > ?fs/ceph/addr.c | 2 +-
> > ?1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
> > index 5eec6f66fe52..fb0238a4d34f 100644
> > --- a/fs/ceph/addr.c
> > +++ b/fs/ceph/addr.c
> > @@ -273,7 +273,7 @@ static void ceph_netfs_issue_op(struct netfs_read_subrequest *subreq)
> > ?	if (err)
> > ?		iput(inode);
> > ?out:
> > -	if (req)
> > +	if (!IS_ERR_OR_NULL(req))
> > ?		ceph_osdc_put_request(req);
> > ?	if (err)
> > ?		netfs_subreq_terminated(subreq, err);
> 
> Good catch.
> 
> David, could you take this into your fscache-next branch?
> 
> Reviewed-by: Jeff Layton <jlayton@kernel.org>

Jeff sent a different fix for this.  Let's just apply his instead.

regards,
dan carpenter