Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/2] iommu: add Unisoc iommu basic driver
To:     Joerg Roedel <joro@8bytes.org>,
        Chunyan Zhang <zhang.lyra@gmail.com>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Chunyan Zhang <chunyan.zhang@unisoc.com>,
        Sheng Xu <sheng.xu@unisoc.com>,
        iommu@lists.linux-foundation.org, Rob Herring <robh+dt@kernel.org>,
        Baolin Wang <baolin.wang7@gmail.com>,
        Orson Zhai <orsonzhai@gmail.com>
References: <20210202073258.559443-3-zhang.lyra@gmail.com>
 <20210202104257.736836-1-zhang.lyra@gmail.com>
 <20210202140101.GA32671@8bytes.org>
From:   Robin Murphy <robin.murphy@arm.com>
Message-ID: <992fad43-c457-d809-3bd7-7fd5b6e8fa22@arm.com>
Date:   Tue, 2 Feb 2021 14:34:34 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <20210202140101.GA32671@8bytes.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021-02-02 14:01, Joerg Roedel wrote:
> On Tue, Feb 02, 2021 at 06:42:57PM +0800, Chunyan Zhang wrote:
>> From: Chunyan Zhang <chunyan.zhang@unisoc.com>
>>
>> This iommu module can be used by Unisoc's multimedia devices, such as
>> display, Image codec(jpeg) and a few signal processors, including
>> VSP(video), GSP(graphic), ISP(image), and CPP(camera pixel processor), etc.
>>
>> Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com>
>> ---
>>   drivers/iommu/Kconfig      |  12 +
>>   drivers/iommu/Makefile     |   1 +
>>   drivers/iommu/sprd-iommu.c | 598 +++++++++++++++++++++++++++++++++++++
> 
> This looks like it actually belongs under drivers/iommu/arm/, no?

Nope, I believe if Arm Ltd. had any involvement in this I'd know about it :)

Robin.