Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v14 11/11] selftests: kvm/x86: add test for pmu msr
 MSR_IA32_PERF_CAPABILITIES
To:     Like Xu <like.xu@linux.intel.com>,
        Sean Christopherson <seanjc@google.com>
Cc:     Vitaly Kuznetsov <vkuznets@redhat.com>,
        Wanpeng Li <wanpengli@tencent.com>,
        Jim Mattson <jmattson@google.com>,
        Joerg Roedel <joro@8bytes.org>, ak@linux.intel.com,
        wei.w.wang@intel.com, kan.liang@intel.com,
        alex.shi@linux.alibaba.com, kvm@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org
References: <20210201051039.255478-1-like.xu@linux.intel.com>
 <20210201060152.370069-1-like.xu@linux.intel.com>
 <20210201060152.370069-5-like.xu@linux.intel.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <f77954f5-02ad-8a40-d7d3-31614628b007@redhat.com>
Date:   Tue, 2 Feb 2021 15:53:38 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <20210201060152.370069-5-like.xu@linux.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 01/02/21 07:01, Like Xu wrote:
> 
> +uint64_t rdmsr_on_cpu(uint32_t reg)
> +{
> +	uint64_t data;
> +	int fd;
> +	char msr_file[64];
> +
> +	sprintf(msr_file, "/dev/cpu/%d/msr", 0);
> +	fd = open(msr_file, O_RDONLY);
> +	if (fd < 0)
> +		exit(KSFT_SKIP);
> +
> +	if (pread(fd, &data, sizeof(data), reg) != sizeof(data))
> +		exit(KSFT_SKIP);
> +
> +	close(fd);
> +	return data;
> +}

In order to allow running as non-root, it's better to use the 
KVM_GET_MSRS ioctl on the /dev/kvm file descriptor.

The tests pass, but please take a look at the kvm/queue branch to see if 
everything is ok.

Paolo