Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Feb 2021 09:22:55 -0600
From:   Jeffrey Mitchell <jeffrey.mitchell@starlab.io>
To:     Tyler Hicks <code@tyhicks.com>
Cc:     ecryptfs@vger.kernel.org, linux-kernel@vger.kernel.org,
        Dan Robertson <daniel.robertson@starlab.io>
Subject: Re: [PATCH] ecryptfs: Fix inodes not being evicted until unmount
Message-ID: <20210202152255.GA3383@jeffrey-work-20.04>
References: <20201218190730.141761-1-jeffrey.mitchell@starlab.io>
 <20210130170640.GA58096@elm>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210130170640.GA58096@elm>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from jeffrey-work-20 (47.218.202.86) by SN6PR04CA0100.namprd04.prod.outlook.com (2603:10b6:805:f2::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.16 via Frontend Transport; Tue, 2 Feb 2021 15:22:58 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: e6722f37-ecba-466c-1ee4-08d8c78e6bf8
X-MS-TrafficTypeDiagnostic: BY3PR09MB8257:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BY3PR09MB8257BAC05240869CCDE63797F8B59@BY3PR09MB8257.namprd09.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:1468;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: xfu52gR+/kHh+woYvAvTEo4U8G+c87loAExi0HJzO4lM2TOwxWvBtCTFlZGG9NEoSRKnL7TmqKzaNh8p0XD03e7a+ewuJ71ty76lY39SNjIzrhLAgyZthC1hzgQWHAjVvrmG5HSMwjTIx4IHmM9tgTvePcZfkkW4KaQr+Z/YwTi6+S+EcmyVuQYxcBjUgBf3I9juYRffmsiqktmdZnIHRHwXeQFAlbg5DHs5Et7SdWy6BY2hxhUF/pWjvweiKW+YeLo4QAwWwF0pnuDtkE0nHyVzvCnuw75YTf5Bz/th0m8ON+h0gyd+Fh3LdMMHDGJw+e/TH2pTZIp36r0fudhN4FLfhM1uJJyDEa3qSyCdQIUhuzmDh81n2avIyZk1of4eOR9bdho/AvLu/pkFHJ7y/Btruig0IW9wKeVlAILv2Nq1VvS44FrmoPuf5vvY0Qk8yzNk+KxPIeI4Cf1ddgP4lhfnvqnssq7AVKFEC6ZYAXkgH/dCrAZlC0XOBbSaLWcOWomNiHPwmMjGDo9x27AieQ==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ0PR09MB7008.namprd09.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39830400003)(376002)(136003)(366004)(396003)(346002)(44832011)(6916009)(316002)(14286002)(4744005)(86362001)(26005)(186003)(8936002)(16526019)(1076003)(5660300002)(2906002)(478600001)(956004)(9686003)(8676002)(6666004)(66946007)(66476007)(66556008)(6496006)(6486002)(4326008)(52116002)(107886003)(33656002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?TP5ABj8WUeSAG17dZPr2Hr7hQUhH4kpAdBR3b9H6Hm3gw4Coc9OzWVZ2Xkrd?=
 =?us-ascii?Q?Wee4Ozdcgj7P2N1cA83BGJB1IdwXESXknos0xMbwYqQPTpE++magjbfUbOG2?=
 =?us-ascii?Q?hU4oheWPUtetGDjoboLAVk/zH+3oxkXsk7Rx0XYo2PU0N2XSrF2CvVklwODU?=
 =?us-ascii?Q?8ZoRHhFdOQTArwt3k/w7TngddEsjCOjtXmNvmJ8l/vFG1ur4uwK1EXzbubWn?=
 =?us-ascii?Q?KnO8wKdJ3D1OAuiTeup3gOdNqnDvigYEIiqmTSWDLBEfWIMaXF5AOknq+2mA?=
 =?us-ascii?Q?NG/l9dq/MNOQEsFBEzlLaX00kXG1Y/3g4hL+OKht2GU/2uSVrhkxMAt8oyp0?=
 =?us-ascii?Q?IEyVrMNeeXjPmQ+5AKuU0H/4pAhg2kq/VqmfBy8aW6djj2Pqe+Arhvx8QVxu?=
 =?us-ascii?Q?iyWysFXfLk3pDEcuXkykbtfolTrbmmAA+5nmOJbBuK1tB6Sk02rBmmpHzTzA?=
 =?us-ascii?Q?1Xw42BUO0XARukvAAgrb0faqwGDzoXXt9PM7nv3tuOREkhwawgNE3f6UDh7i?=
 =?us-ascii?Q?+bNBEtuw/14dHMMAqwRKsjgNpysUy5cKLS+Dbj/O9LSfVdR+FVPGxmjOrmdz?=
 =?us-ascii?Q?gx0RLyOExH0AeFvoxBmsnjcaSM3f+K7zxlZ2FcX53KFk2uv16krgwgkyZMbr?=
 =?us-ascii?Q?bOWZPCnXzc/s7bDY8KFset+Klr0bKi3OsKeqIXW3RJuND6Tukb+HxxZ2pYdY?=
 =?us-ascii?Q?IcV+Pfdl7GkRDO3TJK6g0v7hemLS/Ua2Zvv3FiB1q6MGfhdzLX5wrvO3G7iZ?=
 =?us-ascii?Q?c7ms/Iiwem/gvfEM0jnGNEE2x/vYQIqHcphnW7IMCKANSTOw57wig9redJzJ?=
 =?us-ascii?Q?jsfMsSVtceOeYy8KbpsEVuuj4WwSQtNNk3Zf7PqkEyV9gB01gwFiMl3GH6WR?=
 =?us-ascii?Q?xlToXmJsO+meHHXbG6ggjfxZ7zhoZj2pQ3sdXeWd9aeoYiccyOIHfo+ylJ3+?=
 =?us-ascii?Q?mFPGQFkABjuUq+1VFfUrtMEeQzXMzZ3Vhx5rt0MOzB+Fb1S5ptFv6yAa2w0i?=
 =?us-ascii?Q?do7RbWaeXTRtdFkq6e/SDdTJ00QgiGKCGR4eWe73Du2Kf5pvQN3z7TyaKvQ+?=
 =?us-ascii?Q?CsX5cgqW?=
X-OriginatorOrg: starlab.io
X-MS-Exchange-CrossTenant-Network-Message-Id: e6722f37-ecba-466c-1ee4-08d8c78e6bf8
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR09MB7008.namprd09.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2021 15:22:58.6001
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 5e611933-986f-4838-a403-4acb432ce224
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qnpGELh8TBqI47mtPZpLU+VOsl47XbHLuJPyBZ6Feh/QPmN5oC/TacA9fNtd7i7Kzn8HF+n7umgC9SHIy33mwoK+lkrp1JPW9XrSzhYOoEs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY3PR09MB8257
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Jan 30, 2021 at 11:06:40AM -0600, Tyler Hicks wrote:
> Hey Jeffrey and Dan - thanks for the patch! Unfortunately, I think this
> would allow the eCryptfs inode's nlink count to get out of sync with the
> lower inode's nlink count in the case of direct manipulation to the
> lower filesystem.

Hmm. What if I instead synchronize it before calling vfs_unlink(), then
call drop_nlink() if vfs_unlink() succeeds?

> Is the condition that you're trying to fix a result of going through the
> this code path?
> 
>  ecryptfs_unlink() -> ecryptfs_do_unlink() -> vfs_unlink() -> nfs_unlink() -> nfs_sillyrename() -> nfs_async_unlink()

Yes, that is the code path that causes it.

V/R,
Jeffrey Mitchell