Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp658020pxb;
        Tue, 2 Feb 2021 14:37:14 -0800 (PST)
X-Google-Smtp-Source: ABdhPJzVDif/SsS5+tUPc6k9mY40qZPduZbMGIQ4RCB+rDAjsYWWAMKQj2kVAA5e6hG06CGCqMza
X-Received: by 2002:a05:6402:5206:: with SMTP id s6mr297151edd.92.1612305434289;
        Tue, 02 Feb 2021 14:37:14 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1612305434; cv=none;
        d=google.com; s=arc-20160816;
        b=prHeWGu+WZQ+1ZByrOZsR4GE7s9He5f/3BEKps1/ki0wOdC3kw836TfdPlXsFKQ0pD
         4bRSFqwsrhMRdB74jKzIP4FgNixbT3BVCPqXRH4G0CpTW7Glm6gtyKymnRcJwFe05A0S
         Tn6UAJx1nCCyaaWvPcm5J9DHW6WZ9g49V43ubsmvuXzaf8gIaLUXEd8E762HDih0IbIA
         O0g45qz9skSI1C5EOEYh/c+/tIkmGmcVp2CqMwnmW8clur1SJ1R1aontlYnASbY7gKcW
         n7OExiIl/qvO+buAVQiMwcldHAxDkkjIey2xrryOVOnUgdQJW/yopdtD9MN+cC2Ru7zU
         3EWw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date:dkim-signature;
        bh=7YjFA7pZ3xhaEwssl8dZUbj1IzPqax9Q4DLkRQOrSx8=;
        b=lkp+owGxkoZto9Eg8hwQ1CtLb2PYeJs+k4WJubYSge4ASwcyiwphUX4UZm3v10SHWG
         qQEtBSon3wwDYzc9tXECltUXB7e32arWeW5cSNXqqlZkpQ/+Qu/Khcg+pH147nvDHw0u
         v7sWavq+1CuHQj3cVqY/1FYDEio9f6fgqUa/1sf2XtIK9fX5Mea6RjbUjavSFgllF7Kn
         38jm1TYzkzt04FEjeLnKPglhE+HDTpwG3OfFA+6UwoQBgT3/oACnJooaMlBCfPN1GoEa
         L7JTC2E94WVpyCPCnFTI0BN0QBTZFM/qdE9g8qgLU/P0uG0toYJneK5FpgglkqoKxGaY
         nBMA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Sb8aP7yC;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id hs7si128523ejc.745.2021.02.02.14.36.48;
        Tue, 02 Feb 2021 14:37:14 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Sb8aP7yC;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S235421AbhBBPY4 (ORCPT <rfc822;luelistan@gmail.com> + 99 others);
        Tue, 2 Feb 2021 10:24:56 -0500
Received: from mail.kernel.org ([198.145.29.99]:39392 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S235360AbhBBPQz (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 2 Feb 2021 10:16:55 -0500
Received: by mail.kernel.org (Postfix) with ESMTPSA id 5415464FB0;
        Tue,  2 Feb 2021 15:09:16 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org;
        s=korg; t=1612278556;
        bh=z4vRuafJma6tBlWmFdXpNiK/YoirUh+ynvyhL94wl/A=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=Sb8aP7yC14wg86+f3FSLnhUyAKJ4Iy62J43RREJl+Uwbj0sCVahjPIpgr4oZ+tzHn
         I+t4nUbMn0Q8bx/9GvlRO81jiblgiR407iMFAgIvaIgDBIpIYAyyGJ661l8VEBwVue
         ANp7EU04mu3IVTcItgvF+snpl6Adlw6Y31OhMdKk=
Date:   Tue, 2 Feb 2021 16:09:13 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Benson Leung <bleung@google.com>
Cc:     Kyle Tso <kyletso@google.com>, heikki.krogerus@linux.intel.com,
        bleung@chromium.org, badhri@google.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: Return void in typec_partner_set_pd_revision
Message-ID: <YBlrGTaJQp/pCeJK@kroah.com>
References: <20210202095512.761214-1-kyletso@google.com>
 <YBlpnMKzGBcP5Ybi@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YBlpnMKzGBcP5Ybi@google.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 02, 2021 at 07:02:52AM -0800, Benson Leung wrote:
> Hi Kyle,
> 
> On Tue, Feb 02, 2021 at 05:55:12PM +0800, Kyle Tso wrote:
> > typec_partner_set_pd_revision doesn't need any return value.
> > 
> > Fixes: 29b01295a829 ("usb: typec: Add typec_partner_set_pd_revision")
> > Signed-off-by: Kyle Tso <kyletso@google.com>
> 
> Review tags for <bleung@chromium.org>

What does that mean?

Please respond with a line that I can use...

thanks,

greg k-h