Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1612165363-98394-1-git-send-email-jiapeng.chong@linux.alibaba.com>
In-Reply-To: <1612165363-98394-1-git-send-email-jiapeng.chong@linux.alibaba.com>
From:   Akinobu Mita <akinobu.mita@gmail.com>
Date:   Wed, 3 Feb 2021 00:14:44 +0900
Message-ID: <CAC5umyjm3Xr2t6j3N2XHBa+7gjfYa0jOE+WL9_Sq9AWA=Cs5+w@mail.gmail.com>
Subject: Re: [PATCH] fault_inject: Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
To:     Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc:     LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

2021=E5=B9=B42=E6=9C=881=E6=97=A5(=E6=9C=88) 16:43 Jiapeng Chong <jiapeng.c=
hong@linux.alibaba.com>:
>
> Fix the following coccicheck warning:
>
> ./lib/fault-inject.c:187:0-23: WARNING: fops_stacktrace_depth should be
> defined with DEFINE_DEBUGFS_ATTRIBUTE.
>
> ./lib/fault-inject.c:169:0-23: WARNING: fops_ul should be defined with
> DEFINE_DEBUGFS_ATTRIBUTE.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  lib/fault-inject.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/fault-inject.c b/lib/fault-inject.c
> index ce12621..cb7ea22 100644
> --- a/lib/fault-inject.c
> +++ b/lib/fault-inject.c
> @@ -166,7 +166,7 @@ static int debugfs_ul_get(void *data, u64 *val)
>         return 0;
>  }
>
> -DEFINE_SIMPLE_ATTRIBUTE(fops_ul, debugfs_ul_get, debugfs_ul_set, "%llu\n=
");
> +DEFINE_DEBUGFS_ATTRIBUTE(fops_ul, debugfs_ul_get, debugfs_ul_set, "%llu\=
n");
>
>  static void debugfs_create_ul(const char *name, umode_t mode,
>                               struct dentry *parent, unsigned long *value=
)

Could you just remove this fops_ul stuff and use debugfs_create_ulong() ins=
tead?