Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Feb 2021 07:10:14 -0800
From:   Benson Leung <bleung@google.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     Kyle Tso <kyletso@google.com>, heikki.krogerus@linux.intel.com,
        bleung@chromium.org, badhri@google.com, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: typec: Return void in typec_partner_set_pd_revision
Message-ID: <YBlrVgJJMXqiocv7@google.com>
References: <20210202095512.761214-1-kyletso@google.com>
 <YBlpnMKzGBcP5Ybi@google.com>
 <YBlrGTaJQp/pCeJK@kroah.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="XEo4q5bdcjfPOAx4"
Content-Disposition: inline
In-Reply-To: <YBlrGTaJQp/pCeJK@kroah.com>
Precedence: bulk


--XEo4q5bdcjfPOAx4
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Feb 02, 2021 at 04:09:13PM +0100, Greg KH wrote:
> On Tue, Feb 02, 2021 at 07:02:52AM -0800, Benson Leung wrote:
> > Hi Kyle,
> >=20
> > On Tue, Feb 02, 2021 at 05:55:12PM +0800, Kyle Tso wrote:
> > > typec_partner_set_pd_revision doesn't need any return value.
> > >=20
> > > Fixes: 29b01295a829 ("usb: typec: Add typec_partner_set_pd_revision")
> > > Signed-off-by: Kyle Tso <kyletso@google.com>
> >=20
> > Review tags for <bleung@chromium.org>
>=20
> What does that mean?
>=20
> Please respond with a line that I can use...
>=20

Reviewed-by: Benson Leung <bleung@chromium.org>

Sorry.=20

Benson

> thanks,
>=20
> greg k-h

--=20
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org

--XEo4q5bdcjfPOAx4
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQQCtZK6p/AktxXfkOlzbaomhzOwwgUCYBlrVgAKCRBzbaomhzOw
wrlpAQC2RSA1yb6r7vnrVJ9NdP8Nf5SIvBJuPEdsD5C5omP7TAEAzVUprcBR5JdV
kbMlfO1g6FGMwdsl20KXe0ngnkb7xQ8=
=Y2N6
-----END PGP SIGNATURE-----

--XEo4q5bdcjfPOAx4--