Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Feb 2021 11:31:27 -0500
From:   Peter Xu <peterx@redhat.com>
To:     20200918161902.GX8409@ziepe.ca
Cc:     Jason Gunthorpe <jgg@ziepe.ca>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        John Hubbard <jhubbard@nvidia.com>,
        Leon Romanovsky <leonro@nvidia.com>,
        Linux-MM <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "Maya B . Gokhale" <gokhale2@llnl.gov>,
        Yang Shi <yang.shi@linux.alibaba.com>,
        Marty Mcfadden <mcfadden8@llnl.gov>,
        Kirill Shutemov <kirill@shutemov.name>,
        Oleg Nesterov <oleg@redhat.com>, Jann Horn <jannh@google.com>,
        Jan Kara <jack@suse.cz>, Kirill Tkhai <ktkhai@virtuozzo.com>,
        Andrea Arcangeli <aarcange@redhat.com>,
        Christoph Hellwig <hch@lst.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        "Zhang, Wei" <wzam@amazon.com>
Subject: Re: [PATCH 1/4] mm: Trial do_wp_page() simplification
Message-ID: <20210202163127.GD6468@xz-x1>
References: <27564187-4a08-f187-5a84-3df50009f6ca@amazon.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <27564187-4a08-f187-5a84-3df50009f6ca@amazon.com>
Precedence: bulk

On Tue, Feb 02, 2021 at 04:40:33PM +0200, Gal Pressman wrote:
> Hi Peter & Jason,

Hi, Gal, Jason,

> 
> It seems the hugetlb part was overlooked?
> We're testing if the RDMA fork MADV_DONTFORK stuff can be removed on appropriate
> kernels, but our tests still fail due to lacking explicit huge pages support [1].

I didn't think it high priority only because I think most hugetlbfs users
should be using it shared, but maybe I'm wrong..  Then it got lost indeed.

But I definitely agree it should better be there.

> 
> Peter, was it left unchanged on purpose?
> Are you planning to submit the hugetlb changes as well?
> 
> [1] https://github.com/linux-rdma/rdma-core/pull/883#issuecomment-770398171
> 

I'll prepare a fix soon and post it.  Thanks,

-- 
Peter Xu