Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp675451pxb; Tue, 2 Feb 2021 15:11:24 -0800 (PST) X-Google-Smtp-Source: ABdhPJxBEMmStAI7EBj1NEOmszE36uEyD0wLzA7l/lqYpb6zXkc1ibxG98GtxNnz+gzvq9L3gIIE X-Received: by 2002:a05:6402:1682:: with SMTP id a2mr428421edv.30.1612307484471; Tue, 02 Feb 2021 15:11:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612307484; cv=none; d=google.com; s=arc-20160816; b=eax3kFmBy55zgXwoVM6GM4ybHJ8JNxwhFNclVGsdntXMHn6/6Ey+5VJd9g8mSWRm7H 2wLf3k6WZqJ/y2xobrnCyTonH8c1669cyyjJ0UJ/EDq6BEWWpT8ZZRBeZvRva9SidCHR y8E3setHQUsqK9TY93MDE/lpzk8ZhG63CdQqVdvsyu3qvqr1BdKmyRTxhVp4A00OxDtu klhOrqlbhMgzfxPOXaOR79g7sQSKOkDB4CkCEuKSTBkYFodh9/JFPjm6D6Tn0tmQKsj0 I1N/6cGGw6avcueL0QBkvWEanUrzTjhGSx4XBItwVkfEd2+pKucC3w7Hxu+9xbC0eszK PWEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=eAEmX4T0SFhCX900Vx4u0Ymo1oePmn//2Jt6pbrxJRM=; b=uO/ym2cTxpPDw+qb8wLKCOAVjxOr6YjfqkIAzZwhzjfBvd+5n0bsQ6DSJFOICheWlG 31cx0Y40iaqImmOZbFOI9K8kD5vCbjK9LvSXw4h4gMJDQ45So5PHznBL3uXlr2Q2knHC W/Hxa7XJxa9sDKPPL+kS55E5+YmsgmdzWi+nSPQNLgdAyo3Y6JxkVk1Uey1xHjK4oy71 CwdnnDk0qD1FjaIjqJBl6jEZapabYQBTQthE1RHJZQY5T+fT/V+6YaeJMsH5WXsF98S4 871KM7dyGs9SmdRuDxyNVWBrIm8L6W3ST8BJJlyk8cpl6kHYh5eVmQ5hWosy3Za9O2S4 JTFQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=P4NrsAe6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id sd13si192463ejb.311.2021.02.02.15.10.58; Tue, 02 Feb 2021 15:11:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=P4NrsAe6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236723AbhBBQjl (ORCPT + 99 others); Tue, 2 Feb 2021 11:39:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53760 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236336AbhBBQg3 (ORCPT ); Tue, 2 Feb 2021 11:36:29 -0500 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E9D5C0613ED for ; Tue, 2 Feb 2021 08:33:07 -0800 (PST) Received: by mail-pg1-x529.google.com with SMTP id z21so15239429pgj.4 for ; Tue, 02 Feb 2021 08:33:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eAEmX4T0SFhCX900Vx4u0Ymo1oePmn//2Jt6pbrxJRM=; b=P4NrsAe6VNaTkp+kWO5WECdGg5XEKewsuFO7JZUNV6F7jEkq0C/9vP23BBB57HoGAx vbB6CjOlwF3ataZYUKLSpnvjkLD/+6VtqdoOK+nlXrbOLVNvLXUhECvB90dBJBO//Z2b h3MYWqBXNHbMBnWqnPLAvPbUJW7dq4N6KPS9Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eAEmX4T0SFhCX900Vx4u0Ymo1oePmn//2Jt6pbrxJRM=; b=eyvL+mF6ZPEHEMR2UbREoASH7nupmZ6jIDwPObRYuEZ4tmHJKjSoGqFxqNCESvEH7d tvWzCnCrJ5vPdGOXsHKAyVN59j2WxgD5MTzbbfphQKUMO5gLzU0WMuB/aFz/eOSdZYKe 0w9/hyBoY3/7kP2Ixa/QwBFB5ikQeCiSbW0P2BSgY6IuAP5za6ZhYlCfgJ58GwFWN5cb +6tamZlAKw/Bwvde9xk7citxv1FEGe+5SuW2ZhFv/X2ys385j1Q897s4I7dHT4K0t49J YvisoWj+HG55Vk7ayQwV5heUHGwj5K/T4EXHynzRf814mC+S90JLUMwJrCEftsVMj0WJ I+NQ== X-Gm-Message-State: AOAM533m65SmCC7/rM8ak2y4adrjWKy24RZrEsmZd9dkZmYmyRzT9Hgo +qmuHoSNB55FaxAIbJEny7XuOg== X-Received: by 2002:a63:5b43:: with SMTP id l3mr22400040pgm.369.1612283586702; Tue, 02 Feb 2021 08:33:06 -0800 (PST) Received: from bleung.mtv.corp.google.com ([2620:15c:202:201:f693:9fff:fef4:fc72]) by smtp.gmail.com with ESMTPSA id i7sm22362511pfc.50.2021.02.02.08.33.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Feb 2021 08:33:05 -0800 (PST) From: Benson Leung To: heikki.krogerus@linux.intel.com, enric.balletbo@collabora.com, pmalani@chromium.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kyletso@google.com, bleung@google.com, bleung@chromium.org Subject: [PATCH] platform/chrome: cros_ec_typec: Fix call to typec_partner_set_pd_revision Date: Tue, 2 Feb 2021 08:32:48 -0800 Message-Id: <20210202163248.3981555-1-bleung@chromium.org> X-Mailer: git-send-email 2.30.0.365.g02bc693789-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org typec_partner_set_pd_revision returns void now. Fixes: cefc011f8daf platform/chrome: cros_ec_typec: Set Partner PD revision from status Signed-off-by: Benson Leung --- drivers/platform/chrome/cros_ec_typec.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c index a7778258d0a0..7b93dfd02999 100644 --- a/drivers/platform/chrome/cros_ec_typec.c +++ b/drivers/platform/chrome/cros_ec_typec.c @@ -842,11 +842,7 @@ static int cros_typec_handle_sop_disc(struct cros_typec_data *typec, int port_nu goto disc_exit; } - ret = typec_partner_set_pd_revision(port->partner, pd_revision); - if (ret < 0) { - dev_err(typec->dev, "Failed to update partner PD revision, port: %d\n", port_num); - goto disc_exit; - } + typec_partner_set_pd_revision(port->partner, pd_revision); memset(sop_disc, 0, EC_PROTO2_MAX_RESPONSE_SIZE); ret = cros_typec_ec_command(typec, 0, EC_CMD_TYPEC_DISCOVERY, &req, sizeof(req), -- 2.30.0.365.g02bc693789-goog