Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Feb 2021 18:16:00 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Michael Kelley <mikelley@microsoft.com>
Cc:     Wei Liu <wei.liu@kernel.org>,
        Linux on Hyper-V List <linux-hyperv@vger.kernel.org>,
        "virtualization@lists.linux-foundation.org" 
        <virtualization@lists.linux-foundation.org>,
        Linux Kernel List <linux-kernel@vger.kernel.org>,
        Vineeth Pillai <viremana@linux.microsoft.com>,
        Sunil Muthuswamy <sunilmut@microsoft.com>,
        Nuno Das Neves <nunodasneves@linux.microsoft.com>,
        "pasha.tatashin@soleen.com" <pasha.tatashin@soleen.com>,
        KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@kernel.org>,
        "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v5 15/16] x86/hyperv: implement an MSI domain for root
 partition
Message-ID: <20210202181600.4lk4zber7dogsd6e@liuwe-devbox-debian-v2>
References: <20210120120058.29138-1-wei.liu@kernel.org>
 <20210120120058.29138-16-wei.liu@kernel.org>
 <MWHPR21MB1593FFC6005966A3D9BEA3EFD7BB9@MWHPR21MB1593.namprd21.prod.outlook.com>
 <20210202173153.jkbvwck2vsjlbjbz@liuwe-devbox-debian-v2>
 <MWHPR21MB1593248BE6E343117897FE82D7B59@MWHPR21MB1593.namprd21.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <MWHPR21MB1593248BE6E343117897FE82D7B59@MWHPR21MB1593.namprd21.prod.outlook.com>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Tue, Feb 02, 2021 at 06:15:23PM +0000, Michael Kelley wrote:
> From: Wei Liu <wei.liu@kernel.org> Sent: Tuesday, February 2, 2021 9:32 AM
> > 
> > On Wed, Jan 27, 2021 at 05:47:04AM +0000, Michael Kelley wrote:
> > > From: Wei Liu <wei.liu@kernel.org> Sent: Wednesday, January 20, 2021 4:01 AM
> > > >
> > > > When Linux runs as the root partition on Microsoft Hypervisor, its
> > > > interrupts are remapped.  Linux will need to explicitly map and unmap
> > > > interrupts for hardware.
> > > >
> > > > Implement an MSI domain to issue the correct hypercalls. And initialize
> > > > this irqdomain as the default MSI irq domain.
> > > >
> > > > Signed-off-by: Sunil Muthuswamy <sunilmut@microsoft.com>
> > > > Co-Developed-by: Sunil Muthuswamy <sunilmut@microsoft.com>
> > > > Signed-off-by: Wei Liu <wei.liu@kernel.org>
> > > > ---
> > > > v4: Fix compilation issue when CONFIG_PCI_MSI is not set.
> > > > v3: build irqdomain.o for 32bit as well.
> > >
> > > I'm not clear on the intent for 32-bit builds.  Given that hv_proc.c is built
> > > only for 64-bit, I'm assuming running Linux in the root partition
> > > is only functional for 64-bit builds.  So is the goal simply that 32-bit
> > > builds will compile correctly?  Seems like maybe there should be
> > > a CONFIG option for running Linux in the root partition, and that
> > > option would force 64-bit.
> > 
> > To ensure 32 bit kernel builds and 32 bit guests still work.
> > 
> > The config option ROOT_API is to be introduced by Nuno's /dev/mshv
> > series. We can use that option to gate some objects when that's
> > available.
> > 
> 
> But just so I'm 100% clear, is there intent to run 32-bit Linux in the root
> partition?  I'm assuming not.

That's correct. There is no intent to run 32-bit Linux as the root
partition.

Wei.

> 
> Michael