Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 1/1] ipu3-cio2: Build bridge only if ACPI is enabled
To:     Sakari Ailus <sakari.ailus@linux.intel.com>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-media <linux-media@vger.kernel.org>,
        Dan Scally <djrscally@gmail.com>,
        Bingbu Cao <bingbu.cao@intel.com>,
        Yong Zhi <yong.zhi@intel.com>
References: <20210202201440.10613-1-sakari.ailus@linux.intel.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <070d3585-e21c-0bef-3740-d38fcd106f25@infradead.org>
Date:   Tue, 2 Feb 2021 12:24:54 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <20210202201440.10613-1-sakari.ailus@linux.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2/2/21 12:14 PM, Sakari Ailus wrote:
> ipu3-cio2-bridge uses several features of the ACPI framework that have no
> meaningful replacement when ACPI is disabled. Instead of adding #ifdefs to
> the affected places, only build the bridge code if CONFIG_ACPI is enabled.
> 
> Fixes: 803abec64ef9 ("media: ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver")
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested

Thanks.

> ---
> Hi Randy,
> 
> Thanks for reporting this.
> 
> This patch should address the problem.
> 
>  drivers/media/pci/intel/ipu3/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/pci/intel/ipu3/Kconfig b/drivers/media/pci/intel/ipu3/Kconfig
> index 24f4e79fe0cb..dce8274c81e6 100644
> --- a/drivers/media/pci/intel/ipu3/Kconfig
> +++ b/drivers/media/pci/intel/ipu3/Kconfig
> @@ -20,7 +20,7 @@ config VIDEO_IPU3_CIO2
>  
>  config CIO2_BRIDGE
>  	bool "IPU3 CIO2 Sensors Bridge"
> -	depends on VIDEO_IPU3_CIO2
> +	depends on VIDEO_IPU3_CIO2 && ACPI
>  	help
>  	  This extension provides an API for the ipu3-cio2 driver to create
>  	  connections to cameras that are hidden in the SSDB buffer in ACPI.
> 


-- 
~Randy