Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] dt-bindings: iio: dac: Add missing ad5686 compatible
 strings
To:     Rob Herring <robh@kernel.org>, devicetree@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Michael Auchter <michael.auchter@ni.com>,
        linux-iio@vger.kernel.org
References: <20210202181427.3934218-1-robh@kernel.org>
From:   Lars-Peter Clausen <lars@metafoo.de>
Message-ID: <efbfbb94-bf61-5503-9833-df23709f56a2@metafoo.de>
Date:   Tue, 2 Feb 2021 21:55:56 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <20210202181427.3934218-1-robh@kernel.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

On 2/2/21 7:14 PM, Rob Herring wrote:
> The example uses 'adi,ad5686', but the schema fails to document it. Given
> the filename and there is a similar part AD5686, let's just add the
> compatible strings including the 'r' variant.

There are two variants of this chip. One with a SPI interface and one 
with a I2C interface. This binding document only describes the I2C 
variants. But the ad5686 is a SPI variant.

I think this is a typo and we should replace ad5686 with ad5696, 
including the document name.

>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Michael Hennerich <Michael.Hennerich@analog.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> Cc: Michael Auchter <michael.auchter@ni.com>
> Cc: linux-iio@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>   Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> index 8065228e5df8..190919291828 100644
> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> @@ -19,6 +19,8 @@ properties:
>         - adi,ad5338r
>         - adi,ad5671r
>         - adi,ad5675r
> +      - adi,ad5686
> +      - adi,ad5686r
>         - adi,ad5691r
>         - adi,ad5692r
>         - adi,ad5693