Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Feb 2021 15:10:22 -0600
From:   Rob Herring <robh@kernel.org>
To:     Lars-Peter Clausen <lars@metafoo.de>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Michael Hennerich <Michael.Hennerich@analog.com>,
        Jonathan Cameron <jic23@kernel.org>,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        Michael Auchter <michael.auchter@ni.com>,
        linux-iio@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: dac: Add missing ad5686 compatible
 strings
Message-ID: <20210202211022.GB3706951@robh.at.kernel.org>
References: <20210202181427.3934218-1-robh@kernel.org>
 <efbfbb94-bf61-5503-9833-df23709f56a2@metafoo.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <efbfbb94-bf61-5503-9833-df23709f56a2@metafoo.de>
Precedence: bulk

On Tue, Feb 02, 2021 at 09:55:56PM +0100, Lars-Peter Clausen wrote:
> On 2/2/21 7:14 PM, Rob Herring wrote:
> > The example uses 'adi,ad5686', but the schema fails to document it. Given
> > the filename and there is a similar part AD5686, let's just add the
> > compatible strings including the 'r' variant.
> 
> There are two variants of this chip. One with a SPI interface and one with a
> I2C interface. This binding document only describes the I2C variants. But
> the ad5686 is a SPI variant.

Right, I should have noticed that.

> I think this is a typo and we should replace ad5686 with ad5696, including
> the document name.

Though we do frequently document both I2C and SPI variants in the same 
binding, given there's no existing SPI support and the example is wrong 
I agree.

> > 
> > Cc: Lars-Peter Clausen <lars@metafoo.de>
> > Cc: Michael Hennerich <Michael.Hennerich@analog.com>
> > Cc: Jonathan Cameron <jic23@kernel.org>
> > Cc: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
> > Cc: Michael Auchter <michael.auchter@ni.com>
> > Cc: linux-iio@vger.kernel.org
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> >   Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml | 2 ++
> >   1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> > index 8065228e5df8..190919291828 100644
> > --- a/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad5686.yaml
> > @@ -19,6 +19,8 @@ properties:
> >         - adi,ad5338r
> >         - adi,ad5671r
> >         - adi,ad5675r
> > +      - adi,ad5686
> > +      - adi,ad5686r
> >         - adi,ad5691r
> >         - adi,ad5692r
> >         - adi,ad5693
> 
>