Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp727922pxb; Tue, 2 Feb 2021 16:53:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJxakZN6OxSATCXyqCNjNCqeXkV1WlGPjng18IAzRDqNkkhRmc36i8MYs+cHgYuC00Rzsruf X-Received: by 2002:aa7:c390:: with SMTP id k16mr659648edq.280.1612313615236; Tue, 02 Feb 2021 16:53:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612313615; cv=none; d=google.com; s=arc-20160816; b=oToJc4HwmZMlpwF+doQ8xJZPvf7hWxoc4CYzVqJlDBkVpp2Os36y/ql2Q6xgzkLS3m ch6is9v67OuCh+GVjpSO5OK2KsVvG3gXESmtN5PjkP1GnTZRtYyuLuCzO855JuwPr4dO ZKK1FqlCWrNN8yGdaG6m8cyLC7cUFKXqe9eDMOf/tTVyrf/AfIrRDmi88ze0PQE4DyJn Y3g/IGQnxdA2+dvTu1t9o9CcE6dtoQfXUy31fSFCDfJrWibntlmMV67mXO+FOplHvpVL BXuoCihatpDdzT7E2TPb/DJ8vfcLO7N1ptvT9A99VZzjPjYMwrbP8TIVB5FUSUutkqTl RRlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=wgQE2TzqGwErnqwasqM1aoAmYVPGbSPJe7bzkO3EU2Y=; b=suKdODoQKV/epVRFqbt4yOnhBUYi2C6jqzRnlMvT37gRJzU42+j1B1GkNRafWKuE4G yct6vBJvNmmX7ZhW430BtnaodYas0M8QTWgbuxjLTbxKmq2mWYJrEC85A0JtC7OC/Q+1 Ur/hyb/IpFt5MozWmFcvdq+xHiikP5Uin6YiSP5v/p+FTLWr1iJVTGPo/NyW3lMG9d8P Y2HFD/YAXPYMfcnYUhF1qwuYnCQGJ0WBOMtkQDoKIaaIK8mhNELHSn61UUyo/0zDrrz1 OdKy/sdIlBpKy2d9t3et1PHz+jG93zr+aufV05i6W87d5nQxABnWnSqx1nbn+ctyit/a nC1A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sUDffvXg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i10si326558ejd.325.2021.02.02.16.53.10; Tue, 02 Feb 2021 16:53:35 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=sUDffvXg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234375AbhBBVzA (ORCPT + 99 others); Tue, 2 Feb 2021 16:55:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:56022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232865AbhBBVy4 (ORCPT ); Tue, 2 Feb 2021 16:54:56 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7804064E46; Tue, 2 Feb 2021 21:54:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612302856; bh=XeZmOfUoVNuBsKDrI2Zf2/XMta6hoxfTXzCxxpBleLk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sUDffvXgVeI752W/eYf5S3VNWY6peEBDPpSGOPqaYuGnG+RaC8f+SeAzl1vkKLes3 yhMR7kbVcZOHleUH8Wr9d2zlQFHdvi96vHyqoLx2vsLG2riFmR3Mza5WbUfs8BWPBv 28wfujh4nSQTjEQY133INAuvcJy/UkzWgDTQ2jRV26azVgw3ADwfen4WGv7Wcdj5Gh mhHoOGm8xF9IqdoGpFWpotJIScI6bbIE5U8iyDaCv/UeGHTpRhHnHZDV+QmvGCElOz fzdKzSizCpMPAzHog1dvBajxkQOTiKkoEcVPJkJ3R9p3KMkRD2bVy63XeC0o2tVGtU vc2PzVb6eJMPg== Date: Tue, 2 Feb 2021 23:54:08 +0200 From: Jarkko Sakkinen To: Tianjia Zhang Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Sean Christopherson , Shuah Khan , x86@kernel.org, linux-sgx@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Jia Zhang Subject: Re: [PATCH v4 3/5] x86/sgx: Optimize the free_cnt count in sgx_epc_section Message-ID: References: <20210201132653.35690-1-tianjia.zhang@linux.alibaba.com> <20210201132653.35690-4-tianjia.zhang@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210201132653.35690-4-tianjia.zhang@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 01, 2021 at 09:26:51PM +0800, Tianjia Zhang wrote: > 'section->free_cnt' represents the free page in sgx_epc_section, > which is assigned once after initialization. In fact, just after the > initialization is completed, the pages are in the init_laundry_list > list and cannot be allocated. This needs to be recovered by EREMOVE > of function sgx_sanitize_section() before it can be used as a page > that can be allocated. The sgx_sanitize_section() will be called in > the kernel thread ksgxd. > > This patch moves the initialization of 'section->free_cnt' from the > initialization function sgx_setup_epc_section() to the function > sgx_sanitize_section(), and then accumulates the count after the > successful execution of EREMOVE. This seems to be more reasonable, > free_cnt will also truly reflect the allocatable free pages in EPC. > > Sined-off-by: Tianjia Zhang > Reviewed-by: Sean Christopherson I just copy-paste my earlier response to save time sice you seem to save time by ignoring it and spamming with the same obviously illegit patch. https://lore.kernel.org/linux-sgx/YBGlodsOaX4cWAtl@kernel.org/ /Jarkko