Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Feb 2021 17:34:36 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Timur Tabi <timur@kernel.org>
Cc:     Kees Cook <keescook@chromium.org>, Petr Mladek <pmladek@suse.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        willy@infradead.org, akpm@linux-foundation.org,
        torvalds@linux-foundation.org, roman.fietze@magna.com,
        john.ogness@linutronix.de, akinobu.mita@gmail.com
Subject: Re: [PATCH] lib/vsprintf: make-printk-non-secret printks all
 addresses as unhashed
Message-ID: <20210202173436.6516c676@gandalf.local.home>
In-Reply-To: <9ce56a1c-9ea6-996b-84c6-cfde908c2ecd@kernel.org>
References: <20210202201846.716915-1-timur@kernel.org>
        <202102021351.AEDE896AB3@keescook>
        <9ce56a1c-9ea6-996b-84c6-cfde908c2ecd@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2 Feb 2021 16:19:20 -0600
Timur Tabi <timur@kernel.org> wrote:

> On 2/2/21 3:52 PM, Kees Cook wrote:
> >> A large warning message is displayed if this option is enabled,
> >> because unhashed addresses, while useful for debugging, exposes
> >> kernel addresses which can be a security risk.  
> 
> > Linus has expressly said "no" to things like this in the past:
> > https://lore.kernel.org/lkml/CA+55aFwieC1-nAs+NFq9RTwaR8ef9hWa4MjNBWL41F-8wM49eA@mail.gmail.com/  
> Maybe I misunderstood, but I thought this is what Vlastimil, Petr, 
> Sergey, John, and Steven asked for.

Maybe Linus changed his mind since then?


  "I also suspect that everybody has already accepted that KASLR isn't
   really working locally anyway (due to all the hw leak models with
   cache and TLB timing), so anybody who can look at kernel messages
   already probably could figure most of those things out."

 https://lore.kernel.org/r/CAHk-=wjnEV2E6vCRxv5S5m27iOjHeVWNbfK=JV8qxot4Do-FgA@mail.gmail.com


-- Steve