Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp730140pxb; Tue, 2 Feb 2021 16:58:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJxGO0W9Q6ZyPXe962CoycXrDmthwJQT/eZLI0aXOYxxG9xw4qpfNzP67ufwQAtZRKLELxad X-Received: by 2002:a17:906:b84d:: with SMTP id ga13mr653708ejb.112.1612313893802; Tue, 02 Feb 2021 16:58:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612313893; cv=none; d=google.com; s=arc-20160816; b=tooBmirj81W5GLhrRgWx0ZgxxhxW2e3DmfNupUAVUVFpyVv9h2s15Ioun9ch25QO7z DRk9bKYPTRr2oDGWRrc/exGI/ddjV0jLVkDA+yu0XyBvEclmQAQ6boXEOA4zfZFZl5ZP It4q941jHVpW3kkAtf77CmudXJyDjixqXmf5nxGuK+KMptsdBsDykUY4BXei9uYMfBA/ 3+uc++BmxoMeE3tdBPqBhEcowfl+RUZLoUImHLUPsqOC3wPSdzd3C0QrHRMW5rqyHtIY iRCitjVUUEXFj5oiX9GXS2Sqj1kzV3jjwLH+bXLNhhmaIFM8FhSJA7uFrPWE5SsiSVTO txrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=7ZGbQY3mywPUU0nWA01EU5DfaHN4T/8JO2FRqBkueNY=; b=gGQ39rvSRiKdyNN58+M/jvETpU56rSBnA5GqT7RMUoxcUSsIBaczRdvvR7dUQWhz8Q YEr/jfY/J5dQYJV/Ox+vJmPcs4uTw4utEHjPosne8Yx1y7j4HL1pb/2t23ff819xCYy/ 2TfssSbBx+ceb7K2fBP4tlG5C7zNIN+CBu44Nog929YFTL2RI2ChJui6iKZygf6ESIpV 8Pf27z2jQfPjRzfWj6cHnheqm4Tzeyell3psSWluHQMopdz2jd7URYi/x+SnSvtKrnds XBxZOaf08TDUOvBvwrNgHu/teavFC7TVyo5z7E8rTlV9h9Lj19Q7zu3wt1W/MjxM4ARM /M6w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZHIzuLiL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a12si222205edn.568.2021.02.02.16.57.49; Tue, 02 Feb 2021 16:58:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZHIzuLiL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234372AbhBBW1h (ORCPT + 99 others); Tue, 2 Feb 2021 17:27:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:36492 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235107AbhBBWUE (ORCPT ); Tue, 2 Feb 2021 17:20:04 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 52F0F64EDA; Tue, 2 Feb 2021 22:19:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1612304362; bh=sqKuQs7jQgfFKC1Q1g879kjxuInD33WZU6Kyi8Egc/s=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ZHIzuLiLZYUnhnmDOcDkihUadtik/Hl9/62tXeZxuBIZgmOeS5F6w2tafqAP9+RSZ 6tWnZR37PWEVFo9PFkg1HgUWpn5JNwQDPvox5Agspa/bGIPaDin7dCYN3Cv7KUqX1z uRwiO1hUPHlwldfUNapMM+0VrhDzAtJJBbauqoEVSaT6BvR1W91fn8/nBjuex7dy2P WMEzO80pm1v98Zx1ZthQcdGieCx5WpkeDVKrhsnfEbTssOqX5Ydjur1svvVpPrx2Zi KgTid3VeyZx7fqVuxizToCDvnnvlbPUQKvghI1RCaky/X3JbrZ7w3xuyEh+0o1jWh9 Joo9Jikwe236Q== Subject: Re: [PATCH] lib/vsprintf: make-printk-non-secret printks all addresses as unhashed To: Kees Cook Cc: Petr Mladek , Steven Rostedt , Sergey Senozhatsky , linux-kernel@vger.kernel.org, linux-mm@kvack.org, willy@infradead.org, akpm@linux-foundation.org, torvalds@linux-foundation.org, roman.fietze@magna.com, john.ogness@linutronix.de, akinobu.mita@gmail.com References: <20210202201846.716915-1-timur@kernel.org> <202102021351.AEDE896AB3@keescook> From: Timur Tabi Message-ID: <9ce56a1c-9ea6-996b-84c6-cfde908c2ecd@kernel.org> Date: Tue, 2 Feb 2021 16:19:20 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <202102021351.AEDE896AB3@keescook> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/2/21 3:52 PM, Kees Cook wrote: >> A large warning message is displayed if this option is enabled, >> because unhashed addresses, while useful for debugging, exposes >> kernel addresses which can be a security risk. > Linus has expressly said "no" to things like this in the past: > https://lore.kernel.org/lkml/CA+55aFwieC1-nAs+NFq9RTwaR8ef9hWa4MjNBWL41F-8wM49eA@mail.gmail.com/ Maybe I misunderstood, but I thought this is what Vlastimil, Petr, Sergey, John, and Steven asked for.