Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 2 Feb 2021 15:07:47 -0800
From:   Roman Gushchin <guro@fb.com>
To:     Johannes Weiner <hannes@cmpxchg.org>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        Tejun Heo <tj@kernel.org>, Michal Hocko <mhocko@suse.com>,
        <linux-mm@kvack.org>, <cgroups@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <kernel-team@fb.com>
Subject: Re: [PATCH 1/7] mm: memcontrol: fix cpuhotplug statistics flushing
Message-ID: <20210202230747.GA1812008@carbon.dhcp.thefacebook.com>
References: <20210202184746.119084-1-hannes@cmpxchg.org>
 <20210202184746.119084-2-hannes@cmpxchg.org>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210202184746.119084-2-hannes@cmpxchg.org>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from carbon.dhcp.thefacebook.com (2620:10d:c090:400::5:7ae2) by CO1PR15CA0108.namprd15.prod.outlook.com (2603:10b6:101:21::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3825.17 via Frontend Transport; Tue, 2 Feb 2021 23:07:51 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 13ca1b00-c001-403e-18d3-08d8c7cf5ddc
X-MS-TrafficTypeDiagnostic: BYAPR15MB2216:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BYAPR15MB2216B802C17B76CD154CC66EBEB59@BYAPR15MB2216.namprd15.prod.outlook.com>
X-FB-Source: Internal
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: SkF+4qgJTd4TyMPotYHDo3RT2tVmSLQykIccmo+wk69nj/+eFpXsFWN5i0GizLQbGE1jfocP9WjwrqKNHQTEzNQQQRUR+SiHufIg9SJk+bXWmHAiOv7u9ElhipqSC+Fv4hUGEgLfqcrsIM/fwjw9yoxtqStTspS3Pux6BOH/qwz38C7MZO4OP9jVT70AD6+UKk8ZUWzy2sOA5g2/Nx5Ort6zIrjh8U7GiB4h3JcSUIQ1aTUWrbHtUIj6rCEra2xMm8WGq9UDR+l+SaRZ7ud2+Pij/VPbpm+QWbhDSo8gr+cy3AL8V+TAno5piVvzHQMV4Gtq63h1agYj1Qf6B8wS0AmNOVbXC0n3hgdhU75DGbW934pbRxtSAkWLqAImJiyWyuWgO81t/GBReSAaRSumU8DVsZB9ERGK7zzF+NlAkDWpePlfzwmsiUfapKo+Jw8qvrpE5Olk569bohxEkYkulj+g72M/Hg8mQPUMq509Qg+FeWoUYpEcAt1OmmxiFidwrDGrV7WfHD74sr/7ygXtsw==
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR15MB4136.namprd15.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(396003)(346002)(376002)(366004)(39860400002)(7696005)(6506007)(52116002)(5660300002)(66556008)(66476007)(4744005)(478600001)(16526019)(33656002)(1076003)(316002)(66946007)(8936002)(4326008)(9686003)(6666004)(8676002)(186003)(86362001)(55016002)(6916009)(54906003)(2906002);DIR:OUT;SFP:1102;
X-MS-Exchange-AntiSpam-MessageData: =?us-ascii?Q?xgufFMk7g4pf3IoVYYduq+dXX0MmWYT+PaVhbM3rGjSJZkG6Ubru/4es0pJm?=
 =?us-ascii?Q?q1jRLN2dMHu9UMSZBMk+3LfS+f1ZhCy6FStSX3DNqiQkNBrPXGEBruq7B41V?=
 =?us-ascii?Q?BYgM5DBdRBEP/V0dlvoFZn+S5/R2WiJkHNhHpoRsoMrmkW9V2+/Y0Zb5lsfc?=
 =?us-ascii?Q?EnBh9gJk3GmHUhEc3AlkBQYhu1nEkHB9+hNEJ24c+Yy1sDc1A8ryJWuEZiD6?=
 =?us-ascii?Q?K5B0Ol49p0u55BOuJpnBADrdsyWcMN7LL+r81/QHu7oB2hYqdQEGDYkOCBhW?=
 =?us-ascii?Q?aWy99K1eO+XdjYNTPoBci3+a7LYg63p6quxnFcxzxUzBm/kTCdqlvgPnTCBj?=
 =?us-ascii?Q?HjbLEj4seuGMJpa7g4X7kJ8OcnoCEj7Rm0mC4fzrx3oBGWcJAdhfbE0ajvwz?=
 =?us-ascii?Q?2/jaQIh1pOHP6wJR9RtpIchNXqJzOKOGzM3gWblSUqZfdJwvRYVDAnWaVW2P?=
 =?us-ascii?Q?N+qFBQ7CKEbxZ6u843Tj/1NR5/WgWO7UzDl8xkistiI74koKuCQcOa4e19be?=
 =?us-ascii?Q?Mfhp8+tXmG06xEEP0zkKsg5hQuvLs/+Y9iH7aDM8RFdlAb0DrB5Bp1/rF0L6?=
 =?us-ascii?Q?Hmh1hxQMkFy/4bdwsgKiPL/DQ6zH+KD03mqqdzbOiPxQzwLmVlJ4UD8yT0f5?=
 =?us-ascii?Q?QSxqBzA3HSys4YBWRALu7TTrn+P5urznRU5e588mgcppBEAGEfjm81rgbz9h?=
 =?us-ascii?Q?bNK9UBGoQqEgDXjYS1gkBeQaPvxpfRKzCJsGPxFsKBSUuHCcyw3kyJY0R70L?=
 =?us-ascii?Q?d/AAfznaBHrsb9of6md2k4gpL8actPI4q4Z4QzFCqPUUzx8SV51hFgqVpFs6?=
 =?us-ascii?Q?AezWeqExe91sy6QtPY6uNIPWpZ7aKqVJoZSBn3Bg4M+yckfR0wj0dcM7ekSQ?=
 =?us-ascii?Q?4BL9+kdem8vs8ggvl4X2twGl84oG7NOptbIyK+GeyTS8P2hhBJCzbEq2TtzE?=
 =?us-ascii?Q?xf8BnVlcMpL1eu25ZDgBTz0fG5fHjJF0WcVa5/a+nLkh1BHH8ZbWBJM6iHSd?=
 =?us-ascii?Q?wCrtunxZu7nt7jFYwDXb3V6TAvmsp49VSRWk72ZC0IsEoaNrHioYgt0lC47w?=
 =?us-ascii?Q?IyVYCNoC6NuWPKJDiSu7Cy0buHPiNMhE3SRAsIGMBfY6uZwUW8c=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 13ca1b00-c001-403e-18d3-08d8c7cf5ddc
X-MS-Exchange-CrossTenant-AuthSource: BYAPR15MB4136.namprd15.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2021 23:07:52.2746
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 8wtjIM1QcP5cL3ZvVDyXsgtig8FxgkZM+xbJGZqgKGByTNhlg53zqj6jBjGquvgF
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2216
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737
 definitions=2021-02-02_13:2021-02-02,2021-02-02 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 suspectscore=0
 adultscore=0 impostorscore=0 mlxscore=0 spamscore=0 clxscore=1015
 lowpriorityscore=0 bulkscore=0 phishscore=0 malwarescore=0
 priorityscore=1501 mlxlogscore=889 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2009150000 definitions=main-2102020146
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 02, 2021 at 01:47:40PM -0500, Johannes Weiner wrote:
> The memcg hotunplug callback erroneously flushes counts on the local
> CPU, not the counts of the CPU going away; those counts will be lost.
> 
> Flush the CPU that is actually going away.
> 
> Also simplify the code a bit by using mod_memcg_state() and
> count_memcg_events() instead of open-coding the upward flush - this is
> comparable to how vmstat.c handles hotunplug flushing.

To the whole series: it's really nice to have an accurate stats at
non-leaf levels. Just as an illustration: if there are 32 CPUs and
1000 sub-cgroups (which is an absolutely realistic number, because
often there are many dying generations of each cgroup), the error
margin is 3.9GB. It makes all numbers pretty much random and all
possible tests extremely flaky.

> 
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

To this patch:

Reviewed-by: Roman Gushchin <guro@fb.com>

Thanks!