Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp733833pxb; Tue, 2 Feb 2021 17:03:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJz5qQyz3ojh2jaqBojEn4OasxhLdwdnVZo4POmy6fb6eFegazXIM1eyH1g5LB6WyljndfLm X-Received: by 2002:a05:6402:17a6:: with SMTP id j6mr682835edy.305.1612314227999; Tue, 02 Feb 2021 17:03:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612314227; cv=none; d=google.com; s=arc-20160816; b=i0faxmvSt2rDCjtrxLQtJd8upevDAlxWlalAvxh8P/3Y1VD06AsJL2PTCh3rK68Hu9 HZtaRzC7ivqUxfBG/lBaba+0nr27NEkQrTh7GdifCOWevwx5t2L3ZwZV32p1cjAyzW1B MfbwgUgfjKwYRD9Cs/XJcEZu8p9fgM9NNP1t0Aat9r56QgKAccxxbX53cOkOAimzXbkj s5Dd/SSZXo8yciG/uN7L3PFrGtY2WYZ3oFbORZe+KcNkFTGTq1RVRZ7nGtQPEcjBQuCz 3B2cWiAT/Nj/Hr3GKLsj1CzZrex6wfUFrg9BB28Q7++dYZttFaQrPDn8R1PyCoOxNIbL Zlyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :ironport-sdr:ironport-sdr; bh=0WNPy8rlylAZzL8adkDz9QjH8KQtaB1SvXce9d6qrXQ=; b=q0MxGsOsG2Rf1QK1sAsxYnmW9AWEqyPTJuODB8iQCkqpRwpau4hFQRgH85amT/Pts5 JWU20tPBXBJThsZgsBdl65BHdgc4QH46l84PEb1YIN6gt+6fTnr61O4wiMlgOXoGBPwf kfOmUFNNjic/v7YC/n/dKBsij2yG33mD42NxPFGbelZjP2+iterIcSvexW4g05kSov+S h8dHff48uNO/6u3lFdWbbpMWgfzG8heFjp+KKe+J7LiBHuNlFa2dqDPn2WTuLymVMb2E Zv66XBZ97VQOYMcKvUVkcl1V5mGUm6z6UahIMVbemyzJCEvucrvvXnuZwmn/qbJ4fXT2 dAUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g13si303172ejd.213.2021.02.02.17.03.23; Tue, 02 Feb 2021 17:03:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232972AbhBCAlr (ORCPT + 99 others); Tue, 2 Feb 2021 19:41:47 -0500 Received: from mga18.intel.com ([134.134.136.126]:23758 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232956AbhBCAlq (ORCPT ); Tue, 2 Feb 2021 19:41:46 -0500 IronPort-SDR: 749fQ67NyaAnw9rEKY5zcVvR3X/ABGRa50W0i7tZV1JnL0Qrse898X7mpPApLnGj8HCYpRiNgw jTo3b8c9PCvQ== X-IronPort-AV: E=McAfee;i="6000,8403,9883"; a="168637249" X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="168637249" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 16:41:05 -0800 IronPort-SDR: fSThS5KHbBwVnaWg9jcAyeGQDN3wDWbEJq30e1UJftbL+ccoYFmeFU8bO4UzxOSd4TV3sniJSO 7FR8nRmJ2LvQ== X-IronPort-AV: E=Sophos;i="5.79,396,1602572400"; d="scan'208";a="392022012" Received: from jbrandeb-mobl4.amr.corp.intel.com (HELO localhost) ([10.212.172.218]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Feb 2021 16:41:04 -0800 Date: Tue, 2 Feb 2021 16:41:04 -0800 From: Jesse Brandeburg To: Hariprasad Kelam Cc: , , , , , , , , , , Subject: Re: [Patch v3 net-next 0/7] ethtool support for fec and link configuration Message-ID: <20210202164104.0000180b@intel.com> In-Reply-To: <1612157084-101715-1-git-send-email-hkelam@marvell.com> References: <1612157084-101715-1-git-send-email-hkelam@marvell.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hariprasad Kelam wrote: > This series of patches add support for forward error correction(fec) and > physical link configuration. Patches 1&2 adds necessary mbox handlers for fec > mode configuration request and to fetch stats. Patch 3 registers driver > callbacks for fec mode configuration and display. Patch 4&5 adds support of mbox > handlers for configuring link parameters like speed/duplex and autoneg etc. > Patche 6&7 registers driver callbacks for physical link configuration. For the series, in addition to the fact that Willem already replied to the previous posting of v3 that it looked good. Reviewed-by: Jesse Brandeburg