Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp786991pxb; Tue, 2 Feb 2021 18:47:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJyaYSfxN5sAxo70yjvOAJgCeEoGoyEf74TtP/J5xLuBMFdixa845bE5HxEUTS2s/xtL3Pm+ X-Received: by 2002:a17:906:a147:: with SMTP id bu7mr985040ejb.305.1612320452068; Tue, 02 Feb 2021 18:47:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612320452; cv=none; d=google.com; s=arc-20160816; b=tZYZnicNwAV3zXKl3f0U7O36EHELT0uZn9l9sGq8zjNCklU2ljZodl34VaCbYoz5QF 2USghKlwYrLhhO+f/DbH8D0KFqEg/SAOUE2mu3MhUQBvg3L4NNdC7qTzlR680L510vvA YBdpn02u2kdzx/05bD1g9R4PpWlKlQiP93E2AzCa68g5/NZ0cJd2YzOWjGW1UERkuL3f BeZPmpfeQTy6vguhrGpKZzpt/1ryuk3JzWD1RQa0qIQbsS4byvIv8dql2RGk21eKnj4E OoODrDCOc9VMiNKZpYAqvhHnbWfQR/0mQDsFcHLDus0p6PokmnBIq0Sc7uAwy/Wi2PXa Ah1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=WLExgEfrv7uZodTYeDPoU5MD5+CGpwfAuC6oTnlg0gw=; b=PzXhpuJbCIqWqOUAtPktAOZmeIUyVoaHl3CQBVbQvvbHQro6xmSV3UtRehR95vXD1y ldr68ZvuTsTXo0P6BR10rPU3oP9UA9JYR6snMe1I/vO09GgIvuTCNlbk1VBuJ5j867O/ EpS3Tn6Qb8Is1vObNk+OB6ibi/kkfGXDXLsGqWTHpp5JA6yuJUDCLyWAkYpWesMn62yY CsZxBS2FeE3aNrYJyDNBkeYf5WhGK225tZGUp5BtHgiG/uLuraQblDvc7n7K/hyRLRCN D7Ccad7gkWSKIjdMwhGRlcC04jqW6hjvNB/l2foITdDwALdUWiexDtaS0kSCIDvMQ+3d HATw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id kl24si459502ejc.100.2021.02.02.18.47.07; Tue, 02 Feb 2021 18:47:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231517AbhBCCpZ (ORCPT + 99 others); Tue, 2 Feb 2021 21:45:25 -0500 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]:51325 "EHLO out30-54.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230215AbhBCCpY (ORCPT ); Tue, 2 Feb 2021 21:45:24 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R811e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04357;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0UNjXz5s_1612320271; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UNjXz5s_1612320271) by smtp.aliyun-inc.com(127.0.0.1); Wed, 03 Feb 2021 10:44:38 +0800 From: Jiapeng Chong To: steffen.klassert@secunet.com Cc: herbert@gondor.apana.org.au, davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] esp: Simplify the calculation of variables Date: Wed, 3 Feb 2021 10:44:30 +0800 Message-Id: <1612320270-873-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warnings: ./net/ipv6/esp6.c:791:16-18: WARNING !A || A && B is equivalent to !A || B. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- net/ipv6/esp6.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/esp6.c b/net/ipv6/esp6.c index 2b804fc..153ad10 100644 --- a/net/ipv6/esp6.c +++ b/net/ipv6/esp6.c @@ -788,7 +788,7 @@ int esp6_input_done2(struct sk_buff *skb, int err) int hlen = sizeof(struct ip_esp_hdr) + crypto_aead_ivsize(aead); int hdr_len = skb_network_header_len(skb); - if (!xo || (xo && !(xo->flags & CRYPTO_DONE))) + if (!xo || !(xo->flags & CRYPTO_DONE)) kfree(ESP_SKB_CB(skb)->tmp); if (unlikely(err)) -- 1.8.3.1