Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: kDUqwn7elpv/X0bw4HIH+mskKF/d7c4jxWViRD8fThOpJSaS+rg6VVJkNYnl2BTtnjHmjcEIhV
 XWnBiCqrXPkw==
IronPort-SDR: peD/CeSohs1xq+wtPJu0LOIU0QocDFx1r3nTgnm4Rhg86dkhLSi9EbjKWQyTaW5Kjw87BP5BJr
 FVgvYz64HJKQ==
Subject: Re: [PATCH] mmc: queue: Remove unused define
To:     Chanwoo Lee <cw9316.lee@samsung.com>, ulf.hansson@linaro.org,
        baolin.wang@linaro.org, arnd@arndb.de, colyli@suse.de,
        lee.jones@linaro.org, sartgarg@codeaurora.org, pcc@google.com,
        linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     grant.jung@samsung.com, jt77.jang@samsung.com,
        dh0421.hwang@samsung.com, sh043.lee@samsung.com
References: <CGME20210203072341epcas1p186cca2cf8177a31d04f1ede4bb5f1ec7@epcas1p1.samsung.com>
 <20210203072014.30272-1-cw9316.lee@samsung.com>
From:   Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
Message-ID: <f7984520-8239-24ae-0142-811f4c6d9d9f@intel.com>
Date:   Wed, 3 Feb 2021 09:36:34 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20210203072014.30272-1-cw9316.lee@samsung.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/02/21 9:20 am, Chanwoo Lee wrote:
> From: ChanWoo Lee <cw9316.lee@samsung.com>
> 
> MMC_CQE_QUEUE_FULL is not set and is only cleared.
> Therefore, define is unnecessary.
> 
> Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>

Looks like a pre blk-mq remanent.

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

> ---
>  drivers/mmc/core/queue.c | 2 --
>  drivers/mmc/core/queue.h | 1 -
>  2 files changed, 3 deletions(-)
> 
> diff --git a/drivers/mmc/core/queue.c b/drivers/mmc/core/queue.c
> index 002426e3cf76..9f37a8b909e8 100644
> --- a/drivers/mmc/core/queue.c
> +++ b/drivers/mmc/core/queue.c
> @@ -33,8 +33,6 @@ void mmc_cqe_check_busy(struct mmc_queue *mq)
>  {
>  	if ((mq->cqe_busy & MMC_CQE_DCMD_BUSY) && !mmc_cqe_dcmd_busy(mq))
>  		mq->cqe_busy &= ~MMC_CQE_DCMD_BUSY;
> -
> -	mq->cqe_busy &= ~MMC_CQE_QUEUE_FULL;
>  }
>  
>  static inline bool mmc_cqe_can_dcmd(struct mmc_host *host)
> diff --git a/drivers/mmc/core/queue.h b/drivers/mmc/core/queue.h
> index fd11491ced9f..57c59b6cb1b9 100644
> --- a/drivers/mmc/core/queue.h
> +++ b/drivers/mmc/core/queue.h
> @@ -81,7 +81,6 @@ struct mmc_queue {
>  	int			in_flight[MMC_ISSUE_MAX];
>  	unsigned int		cqe_busy;
>  #define MMC_CQE_DCMD_BUSY	BIT(0)
> -#define MMC_CQE_QUEUE_FULL	BIT(1)
>  	bool			busy;
>  	bool			use_cqe;
>  	bool			recovery_needed;
>