Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp148836pxb; Wed, 3 Feb 2021 01:54:21 -0800 (PST) X-Google-Smtp-Source: ABdhPJzn3fM/c1YRirM/QWskhI+GsB26kjWVWGpbjcbgOPrcgTpjS9r0VL6woR9kZNFj9wCVFUTp X-Received: by 2002:a50:d7c7:: with SMTP id m7mr2042257edj.260.1612346060977; Wed, 03 Feb 2021 01:54:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612346060; cv=none; d=google.com; s=arc-20160816; b=vofX8wVMUefYSpA9S6Cveaqsw9FsBH08hr3XmFQtMQFQ+XboHxEfLnNH5h1dxO65JQ pVJqg5J80Q7e5enG12Gb2Lg4iqqF6AZsAIJ4v+fSPZh7jc6pKFoabwOhcvFiOqDrFmbU 8N5HrYy/d2YDWi1vAvT5gxX09g3JR63RItticf34budHL72tWG8oONtQCNQJnH1EBx4y 8BtO0L/ZOhUaqUMogAJ3n+bjjoEQCnOwYO1X7VWLD9/wnAnnAIc1EmnCutB70Z32ZoIM xbHNkgYwtcyKY2R6Yc+Qh8kk/LHczpd1muMC8IY0jwpuGNxew6aTxhGjO72N7Mn9gUQT giWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=mUBBYPQgd743YMYOWahHHHxNIDhC1EJD+vHL2tn0Yr8=; b=EuoAiXqTtV3xD/yUnnAu54CkZP//mZPJDFEmRroMlZdjJMvA6H1jAlMUIeB95FHmjf vRuNmb6ieT4zEzOemKOcjBbA5/IoCwxfEISe3vxqO60H3dNhuP8Of1USgPBg7U4/wbdN KbtPyK/RgIS+zeTL4uExqSsuz1Ldh47WUH6J3zJQgx0R7IBp87+nd1L+0K8tKCPTZXxk PBExoGmWiYwvT3Em/dNPOm3Ue6UkAuULA7NjPx+SNtRBdaO0O+vX8KFuBxEgUhS23zjK So9TxVpNsfgN1YJWj4q5jMqOUyMYD0PtaaOg/o3JngkaTwDt0qOqvJubFLFw1L4PGp7P 40Dw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dx12si1002845ejb.547.2021.02.03.01.53.57; Wed, 03 Feb 2021 01:54:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233650AbhBCJwh (ORCPT + 99 others); Wed, 3 Feb 2021 04:52:37 -0500 Received: from verein.lst.de ([213.95.11.211]:50338 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233644AbhBCJwb (ORCPT ); Wed, 3 Feb 2021 04:52:31 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 671BF6736F; Wed, 3 Feb 2021 10:51:48 +0100 (CET) Date: Wed, 3 Feb 2021 10:51:48 +0100 From: Christoph Hellwig To: Filippo Sironi Cc: serebrin@amazon.com, dwmw@amazon.co.uk, kbusch@kernel.org, axboe@fb.com, hch@lst.de, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: Add 48-bit DMA address quirk Message-ID: <20210203095148.GA8897@lst.de> References: <20210203094338.19473-1-sironi@amazon.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210203094338.19473-1-sironi@amazon.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 03, 2021 at 10:43:38AM +0100, Filippo Sironi wrote: > Certain NVMe controllers don't support 64-bit DMA addresses. Instead, > they are limited to 48-bit DMA addresses. Let's add a quirk to use them > properly. WTF? This is such a grave NVMe spec compiance bug that I do not think we should support this buggy mess in Linux.