Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp186374pxb; Wed, 3 Feb 2021 03:04:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJx1/o2aPAmLydWe+xiWAMqxjr8FUBD3VEea+EVQ+xxRXuXMbLIh1E3bQEWoYQ4RkthcK4gx X-Received: by 2002:a17:906:4e4b:: with SMTP id g11mr215188ejw.3.1612350258400; Wed, 03 Feb 2021 03:04:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612350258; cv=none; d=google.com; s=arc-20160816; b=d2YrajsTOPLkNQMppb9KEnvvTGGW2F4jPBUv9zyUJ0bU7jjeglfsP0sLET9z/OXgzj NfXp+gkkCXJhXi/OoB0zJEY1U/g4lwnIT59Tes18RHHB/XUPvHFf5FGLkFOVkMGuD2up Y07wUEcG4XKbpUtEawdA3ngaKOW+uej9CgzzF0WJQOeefl9rzDu+POZFI4KS0FGbMdIr s0V69yOMWa1H03J++Ue5klU+83lEoIw4apc+4AlH6bsYGZoae4jVFjz1rGUL8HcbvRZY yF7nL9hs7PLDpqK/KlmcWC7U0DZwu9tDqED1fsvyrT9CsYW9b/hrsewIYKEkB5J6iFNl JuUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=GDYq4I+T5EpQpfmBYOVPSoNRRZobwHssNzSwI/bSDyA=; b=HV00WqaY+KYs0SRrae5FlGJG7j3x2PBO3LGOPnB8Y2Kz73D0ZE2YknGhB4orUWCic4 GpQwM+eOue/fa1nFv/NaYxC78sb0PbyxtfwRyhJ+QkzRdbIUK8/Px2Uuvz8a68cXtngb fWJ0h1t9O95IakqZI6EzF2mm/BCAk8jLKShEMku2KTl2h7xgEpPg6+S5vHzxgcxatTQn LgxqvycupALu9tqda9/75Nf2A2cVI8SWM35V7X2UD9bDWC54MUTyi1Yz0apBB/OeVzGc TMR01OwsScsOCqLHV7pfW3blsCi//EivouaYKIO74BoYBYUBxCRvmTVfat6+ElcuPKed +GDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=W8GLfKg5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w14si1029601ede.222.2021.02.03.03.03.53; Wed, 03 Feb 2021 03:04:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=W8GLfKg5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233878AbhBCLBW (ORCPT + 99 others); Wed, 3 Feb 2021 06:01:22 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:12734 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S233508AbhBCLBT (ORCPT ); Wed, 3 Feb 2021 06:01:19 -0500 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 113AVS9c000907; Wed, 3 Feb 2021 06:00:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : reply-to : references : mime-version : content-type : in-reply-to; s=pp1; bh=GDYq4I+T5EpQpfmBYOVPSoNRRZobwHssNzSwI/bSDyA=; b=W8GLfKg5jLk25fgAwv6sP5GP8Oc5u5/6hQiXdbxf5V/XH0sKWEeAkYoo6dO1VFiOXKS4 RMh6OWqLyG1l/O40ZSaGJfWt1n4wocLlf0SFOp7coXHtbRjJXY9KwqloMNQr6DqEPPxB 6HV0MCkvzniUQGzEcfNEZiQvRij/6KwzSnlXF1W3ek2wDkhJF0tAeokxMZX3D8m4H4Sm jjEtu2HW67WKWJPt8a6Q2Rf3HV5h7GvhNLq+K/egEe5TN4637hsMMnoF7GPmWHETvNg9 nsXoOT/0DeJY/2B4Bts4fp8go4i4RGueHf6H+GWkZ7hz+WV5SbFapdWdTVq7+MyJSMC2 lw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com with ESMTP id 36fsncsvq7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 03 Feb 2021 06:00:03 -0500 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 113Ak0SV060791; Wed, 3 Feb 2021 06:00:03 -0500 Received: from ppma05fra.de.ibm.com (6c.4a.5195.ip4.static.sl-reverse.com [149.81.74.108]) by mx0b-001b2d01.pphosted.com with ESMTP id 36fsncsvnf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 03 Feb 2021 06:00:03 -0500 Received: from pps.filterd (ppma05fra.de.ibm.com [127.0.0.1]) by ppma05fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 113AwA50009326; Wed, 3 Feb 2021 11:00:01 GMT Received: from b06cxnps3075.portsmouth.uk.ibm.com (d06relay10.portsmouth.uk.ibm.com [9.149.109.195]) by ppma05fra.de.ibm.com with ESMTP id 36cy381yu5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 03 Feb 2021 11:00:01 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 113AxxNP48365846 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 3 Feb 2021 10:59:59 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E965411C052; Wed, 3 Feb 2021 10:59:58 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 85ABC11C050; Wed, 3 Feb 2021 10:59:56 +0000 (GMT) Received: from linux.vnet.ibm.com (unknown [9.126.150.29]) by d06av25.portsmouth.uk.ibm.com (Postfix) with SMTP; Wed, 3 Feb 2021 10:59:56 +0000 (GMT) Date: Wed, 3 Feb 2021 16:29:55 +0530 From: Srikar Dronamraju To: Yue Hu Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, linux-kernel@vger.kernel.org, huyue2@yulong.com, zbestahu@163.com Subject: Re: [PATCH] sched/topology: Switch to sched_debug() for conditional sched domain printk Message-ID: <20210203105955.GF1239129@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20210203042010.799-1-zbestahu@gmail.com> <20210203095256.vzduw2gpcpum6a7g@linux.vnet.ibm.com> <20210203181019.00007024.zbestahu@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20210203181019.00007024.zbestahu@gmail.com> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.737 definitions=2021-02-03_04:2021-02-03,2021-02-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 phishscore=0 suspectscore=0 impostorscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2102030061 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Yue Hu [2021-02-03 18:10:19]: > On Wed, 3 Feb 2021 15:22:56 +0530 > Srikar Dronamraju wrote: > > > * Yue Hu [2021-02-03 12:20:10]: > > > > > > sched_debug() would only be present in CONFIG_SCHED_DEBUG. Right? > > In which case there would be a build failure with your change in > > !CONFIG_SCHED_DEBUG config. > > > > or Am I missing something? > > sched_debug() is also defined for !CONFIG_SCHED_DEBUG as below: > > static inline bool sched_debug(void) > { > return false; > } > ah .. right .. somehow I missed this. -- Thanks and Regards Srikar Dronamraju