Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp202178pxb; Wed, 3 Feb 2021 03:30:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJwu1EHFOWQ5kKVV2DOY9fFxgO36gRQr56qtINx2jJvfmCrCFiKDQgFwkJ67/hJlThqByv9d X-Received: by 2002:a17:906:3e14:: with SMTP id k20mr2690844eji.42.1612351812693; Wed, 03 Feb 2021 03:30:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612351812; cv=none; d=google.com; s=arc-20160816; b=OhrhKRbBhzfKz0DRDd8hJNLMznj0WTGbDcb/ESY+1gQPr8u1wxQsj+sm1BYL+LTanC kQ+vgO1cHOFgYFKRZRslKt354hrj+1Wq8uKYOgrR2pxui+bqJKjP9RMB5/sLYVfprqAo xD32DIj449KLqPpQ4wXSRG9L1pjtHxgl7NojBI1JtgCs32qh3G4Vhm824O3n8AW2bbDs fF+Oet2X6QFd5YP7vTMYMvIvPP67EEZV7zzibbMLwjJMt3Ws4L1AqawFsqQU1pDbwzrN 3ZcTLEZUD1ImClkeUL1HWvQxhFAG0/5RQOJ31sZQltgp5TGW+phQ3u5a/hUAUXHtjAZ1 5MSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=6nKaK1Ri/EFKvS1lMVYxQY3wEgQU439CS+20nr+tGYs=; b=lR5uqjvbghZ3lilb233GnYD+rw/hdEZBeSt66rMqq8shKARNTK67DXnFR/igOhNk9Y DuharNbTwDh4RLdOwU6hEQLbd8p7Huge/P8LfUBUcDRy6hET/kTTD4z9iKz7PTAZIam7 z9bMN0vr5pOMgBIFdIboaMHWm/zSVNBBAFs3NKCsTHLhXuZYU3Z6driJSTrMjM4jLXHn Q9TQTE3pRD4kvS53sCRUKZNLRFyi6+eeHwAjTqwv3G8U4XfOWh2wtwwiMBPWgKdT61xP 8cGWys42QUsR0ETftdi5NgInXjCSogDDTMuGp2qyDmbgkYezNE3bF58rA2zOCbYSkZC7 fNjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn19si1155173ejc.106.2021.02.03.03.29.47; Wed, 03 Feb 2021 03:30:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234392AbhBCL3M (ORCPT + 99 others); Wed, 3 Feb 2021 06:29:12 -0500 Received: from verein.lst.de ([213.95.11.211]:50696 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234158AbhBCL12 (ORCPT ); Wed, 3 Feb 2021 06:27:28 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 0361B67357; Wed, 3 Feb 2021 12:26:46 +0100 (CET) Date: Wed, 3 Feb 2021 12:26:45 +0100 From: Christoph Hellwig To: Filippo Sironi Cc: Christoph Hellwig , serebrin@amazon.com, dwmw@amazon.co.uk, kbusch@kernel.org, axboe@fb.com, sagi@grimberg.me, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nvme: Add 48-bit DMA address quirk Message-ID: <20210203112645.GA11942@lst.de> References: <20210203094338.19473-1-sironi@amazon.de> <20210203095148.GA8897@lst.de> <0c38f5eb-41ef-7934-940b-77b6e73c5239@amazon.de> <20210203111548.GA11075@lst.de> <396b45d5-3dd5-8159-34c2-5668510d1d68@amazon.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <396b45d5-3dd5-8159-34c2-5668510d1d68@amazon.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 03, 2021 at 12:22:31PM +0100, Filippo Sironi wrote: > To avoid issues, it is easier to apply the quirk to all Amazon NVMe > controllers for now till the new lines of controllers with the fix comes > out. At that point, we'll be able to restrict the application to the known > bad controllers. No, that is simply not acceptable. For one we've had enough cases where knowlege about old devices was lost after a decade or so. And secondly shipping more of these broken devices should be as painful as possible for you so that it preferably does not happen at all.