Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750720AbWITUT4 (ORCPT ); Wed, 20 Sep 2006 16:19:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750722AbWITUT4 (ORCPT ); Wed, 20 Sep 2006 16:19:56 -0400 Received: from gateway-1237.mvista.com ([63.81.120.158]:53941 "EHLO gateway-1237.mvista.com") by vger.kernel.org with ESMTP id S1750720AbWITUTz (ORCPT ); Wed, 20 Sep 2006 16:19:55 -0400 Subject: Re: 2.6.18-rt1 From: Daniel Walker To: Ingo Molnar Cc: Gene Heskett , linux-kernel@vger.kernel.org, paulmck@us.ibm.com, Thomas Gleixner , John Stultz , Dipankar Sarma , Arjan van de Ven In-Reply-To: <20060920194650.GA21037@elte.hu> References: <20060920141907.GA30765@elte.hu> <1158774118.29177.13.camel@c-67-180-230-165.hsd1.ca.comcast.net> <20060920182553.GC1292@us.ibm.com> <200609201436.47042.gene.heskett@verizon.net> <20060920194650.GA21037@elte.hu> Content-Type: text/plain Date: Wed, 20 Sep 2006 13:19:49 -0700 Message-Id: <1158783590.29177.19.camel@c-67-180-230-165.hsd1.ca.comcast.net> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1127 Lines: 36 On Wed, 2006-09-20 at 21:46 +0200, Ingo Molnar wrote: > * Gene Heskett wrote: > > > That looks like the chorus of the song I saw when it crashed on boot, > > pretty darned close to identical. > > ok, i've uploaded -rt3: > > http://redhat.com/~mingo/realtime-preempt/ > > this should have this one fixed. > > Ingo What about the !PREEMPT_RT case.. It still wouldn't disable interrupts in the below.. - local_irq_save(flags); if (up->port.sysrq) { /* serial8250_handle_port() already took the lock */ locked = 0; } else if (oops_in_progress) { - locked = spin_trylock(&up->port.lock); + locked = spin_trylock_irqsave(&up->port.lock, flags); } else - spin_lock(&up->port.lock); + spin_lock_irqsave(&up->port.lock, flags); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/